Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

markdown-it-py plugin for embeddable fenced blocks #1496

Closed
3 tasks done
miteshashar opened this issue Sep 26, 2022 · 0 comments · Fixed by #1480
Closed
3 tasks done

markdown-it-py plugin for embeddable fenced blocks #1496

miteshashar opened this issue Sep 26, 2022 · 0 comments · Fixed by #1480
Assignees

Comments

@miteshashar
Copy link
Contributor

miteshashar commented Sep 26, 2022

  • Fenced blocks being used for rendering embeddable diagrams, mindmaps, flowcharts, etc need to be changed to accept syntax similar to that of MyST roles & directives.
  • This change needs to be handled on the front-end too by using the same css classes for activation.
  • Write tests
miteshashar added a commit that referenced this issue Oct 19, 2022
@miteshashar miteshashar self-assigned this Oct 19, 2022
miteshashar added a commit that referenced this issue Oct 20, 2022
miteshashar added a commit that referenced this issue Dec 7, 2022
miteshashar added a commit that referenced this issue Dec 7, 2022
miteshashar added a commit that referenced this issue Dec 13, 2022
* New markdown config profiles structure

* Remove smartquotes. Correct profiles for update and venue

* Generic markdown profiles: basic, document, text-field. Future provision for preset configs in markdown-it-py style class.make().

* Introduced MarkdownColumnNative, that uses the new markdown config profiles. WIP #1485

* Use MarkdownColumnNative for venue(basic) and venue_room(document, for some experimental testing on production, since this is a dormant field)

* Removed funnel.utils.markdown.extmap #1483

* Revamp markdown tests for new config profile structure #1486

* Effort to clean up markdown tests by segregating and moving all debug logic out of the main tests. #1490

* Corrected rendering issues with markdown-it-py plugin for ins #1493

* Cleaned up and reintroduced markdown-it-py plugin for sub & del.

* Ported markdown-it-sup #1493

* Markdown-it-py sub tag plugin now ported from javascript. Correction in rule placement for sup tag plugin. Simple plugin to replace <s> with <del>. #1493

* Plugin for mark tag using == #1493

* Markdown-it-py plugin for embeds, ported from mdit_py_plugins.container & mdit_py_plugins.colon_fence. #1496

* Small correction to 522f114 #1496

* Markmap, Mermaid and Vega integration handled with new Markdown #1496

* Resize markmap container on window resize #1496

* Use document profile for Proposal.body #1485

* Resolves some of the issues in review for #1480

* Classes for markdown profiles. #1480

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Corrected preview bug - send profile to markdown API. Switched markdown() to accept pre-defined string key or a MarkdownProfile subclass as profile argument. #1480

* Better class-based tests structure for markdown. #1490

* Functionality to update expected output for markdown tests. #1490 Resolves #1506

* Generate markdown debug output.html file. Cleanup. #1490 Also small changes in profile structure for #1480

* Commit missed in 740ea5c Related to #1480

* Updated expected_output for the test basic.html to accommodate for change of output for ~text~ from using <s> to <del> #1493

* Tests for markdown-it-py plugins for ins/del/sup/sub/mark #1493

* Tests for embeddable fenced blocks for markmap, vega-lite and mermaid #1496

* Tests for embeddable fenced blocks for markmap, vega-lite and mermaid #1496

* Introduce prismjs to render fenced blocks with language-* output. #1515

* Fix delete operation in labels and submission form page (#1516)

* Fix delete

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Bump loader-utils from 2.0.2 to 2.0.3 (#1514)

Bumps [loader-utils](https://github.com/webpack/loader-utils) from 2.0.2 to 2.0.3.
- [Release notes](https://github.com/webpack/loader-utils/releases)
- [Changelog](https://github.com/webpack/loader-utils/blob/v2.0.3/CHANGELOG.md)
- [Commits](webpack/loader-utils@v2.0.2...v2.0.3)

---
updated-dependencies:
- dependency-name: loader-utils
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Fix breakage caused by Flask-SQLAlchemy 3.0 (#1511)

* [pre-commit.ci] pre-commit autoupdate (#1518)

updates:
- [github.com/jazzband/pip-tools: 6.9.0 → 6.10.0](jazzband/pip-tools@6.9.0...6.10.0)

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

* Fix delete

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Fix review comments

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Kiran Jonnalagadda <[email protected]>

* Add explicit timeout for all requests (#1521)

* Disable the strikethrough token for markdown's basic profile

* Changes in profiles. Basic is now just commonmark. Document is GFM plus our plugins. Text field only has support for strong, emphasis and single backticks.

* Updated expected output of markdown tests, subsequent to changes in profile definitions.

* In markdown_cached_column, moved the custom composite class outside the function, into a dict containing these classes. #1480

* Removed comments now not required. Corrected docstring for markdown()

* Use new markdown_cached_column for all markdown columns #1485

* Removed imports not required anymore #1485

* ToC plugin #1533

* Improved UX for embeds #1496

* Since markdown embed content is now in a hidden container, it can be placeed in a pre. Now, it is skipped by the preview function. #1480

* Call initEmbed for submission guidelines expansion.

* Prism activation bug for SPA navigation solved #1515

* Updated expected output for embed tests to accommodate the latest markup changes made in the embeds plugin. #1496

* Added linkedin URL with colons to markdown test case in links.toml

* Use a registry for profiles

* Rename constructor to 'create'

* Move linkify config into profile

* Merge profiles into base file

* Added comments for markdown tests. Changed parametrization for markdown tests, to have contextual test case identfiers, instead of case<n>.

* Use a dataclass for markdown parser config

* Remove default_factory for MarkdownConfig

* Add 'default' to allowed values for MarkdownConfig.preset.

* Move MarkdownCase and MarkdownTestRegistry inside pytest_generate_tests

* Move render method into config class

* Empty config is not missing config

* Use single quotes and constant var

* Moved pytest_generate_tests and the data for markdown to the markdown tests folder.

* Additional string quotes and char constants

* MarkdownPlugin registry

* Fix docstring

* Move conftest further down to subfolder

* Fix CSS for typeform scroll bug.

* Rename unified_diff_output to fail_with_diff

* Added debounceInterval in markmap.js. Removed unnecessary console statement in formhelper.js. Handled unnamed function in comments.js.

* Bind resizeMarkmapContainers callback to Markmap in markmap.js

* In initEmbed, send parentContainer to addVegaSupport.

* Markdown-it-py plugin to add language-none class code fences without a language. Always load Prismjs styles. Consequent changes in JS flow and tests.

* Use the document profile for the Update.body column.

* Reverse unnamed function correction made in comments.js.

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Kiran Jonnalagadda <[email protected]>
Co-authored-by: Vidya Ramakrishnan <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant