Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Markdown code upgrade #1835

Merged
merged 9 commits into from
Aug 22, 2023
Merged

Markdown code upgrade #1835

merged 9 commits into from
Aug 22, 2023

Conversation

miteshashar
Copy link
Contributor

@miteshashar miteshashar commented Jul 31, 2023

Upgrades to markdown code to align with changes in markdown-it-py==3.0.0

Resolves #1829

@miteshashar miteshashar requested a review from jace July 31, 2023 18:41
Copy link
Member

@jace jace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs a deps rebuild for 3.7. I'll add that.

funnel/utils/markdown/base.py Show resolved Hide resolved
@jace
Copy link
Member

jace commented Aug 1, 2023

Just realised MDIT 3.0 drops Python 3.7, so this PR is blocked until we too drop 3.7.

@jace jace merged commit 415d6a3 into main Aug 22, 2023
@jace jace deleted the markdown-upgrade branch August 22, 2023 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade our markdown implementation to align with markdown-it-py==3.0.0
2 participants