Skip to content
This repository has been archived by the owner on Apr 28, 2020. It is now read-only.

Locked status for UserEmail and UserPhone #224

Closed
3 tasks
jace opened this issue Oct 12, 2017 · 2 comments
Closed
3 tasks

Locked status for UserEmail and UserPhone #224

jace opened this issue Oct 12, 2017 · 2 comments

Comments

@jace
Copy link
Member

jace commented Oct 12, 2017

UserEmail and UserPhone are considered verified data, in that the record exists only if there is a verified link to a user (related: #178). This verification is used to prevent a competing UserEmailClaim or UserPhoneClaim from being created.

However, email claims are still possible in Hasjob (new job post) and Boxoffice (new order or assignee), as those apps prioritise documents over user principals (see #220). This can be a nuisance for a user who is the target of abuse, or who happens to have a common name email address that others mistakenly assume is theirs (as happens often to @kushaldas).

  • UserEmail and UserPhone should have an optional flag named locked that prevents such email claims from being created unless the user is logged in.
  • Lastuser must provide an API to check for locked status, and
  • Apps (Hasjob and Boxoffice) must use this to refuse a locked email address unless the user is logged in. (It's unclear how Boxoffice will do this when embedded in a third-party website that has no Lastuser login.)

There is a related but distinct issue with unwanted email/SMSes to someone who has no interest in creating an account, much less locking it. A solution is briefly discussed in hasgeek/listman#8 but merits a separate ticket.

Caveats:

  1. What happens if there is a hard bounce of email? If the record is removed as per Removing emails from accounts #135 and Remove email on hard bounce #160, the locked status goes away as well. There is no equivalent workflow for hard bounce of SMS, unfortunately, as phones are by definition only intermittently reachable.

  2. Does the locked status apply for password reset/account recovery emails? Refusing to send an email/SMS may totally lock the user out. Perhaps this should be an account-level lock (2FA, security questions, etc) instead of an email/phone lock.

@jace
Copy link
Member Author

jace commented Sep 28, 2018

As of 33fb9b3 in #233, phone verification attempts are locked for an hour if an incorrect PIN is provided thrice.

@jace
Copy link
Member Author

jace commented Oct 1, 2018

Locking should be a client app concern, ideally in the primary app (Funnel or Hasjob). Closing this ticket.

@jace jace closed this as completed Oct 1, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant