Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Semi colons matter #10

Open
caspervonb opened this issue Nov 5, 2016 · 2 comments
Open

Semi colons matter #10

caspervonb opened this issue Nov 5, 2016 · 2 comments
Labels
bug question
Milestone
1.0.0

Comments

@caspervonb
Copy link
Contributor

I'm filing this as a bug, better yet just don't use semicolons!

During freestyle testing I've found that not using semicolons can throw things off, most likely its due to the diff getting it wrong.
@caspervonb caspervonb added the bug label Nov 5, 2016
@caspervonb caspervonb modified the milestone: 1.0.0 Nov 6, 2016
@caspervonb
Copy link
Contributor Author

Added the question label, because, is this a bug? Rely on automatic semi-colon insertions and there be shotguns afoot 😁

@caspervonb caspervonb modified the milestone: 1.0.0 Nov 21, 2016
@caspervonb
Copy link
Contributor Author

Working towards a resolution, which basically means being less dependent on textual diffs and doing a structural diff instead (semi colons changes matter because it expands the boundary of an expression, causing cache misses).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug question
Projects
None yet
Milestone
1.0.0
Development

No branches or pull requests
1 participant
@caspervonb