Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove duplication of web3 client verrsion method #3508

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

natanasow
Copy link
Collaborator

@natanasow natanasow commented Feb 25, 2025

Description:

Currently, there are two implementations of the web3 client version method.

Solution:

Research why we've added both of them (is the first one deprecated) and remove the non-standard one.

Related issue(s):

Fixes #3505

Notes for reviewer:

After some research, we found out that there is no web3_client_version in any JSON RPC standard even in the deprecated ones.

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@natanasow natanasow self-assigned this Feb 25, 2025
@natanasow natanasow added the enhancement New feature or request label Feb 25, 2025
@natanasow natanasow added this to the 0.68.0 milestone Feb 25, 2025
@natanasow natanasow marked this pull request as ready for review February 25, 2025 09:00
@natanasow natanasow requested review from a team and Nana-EC as code owners February 25, 2025 09:00
Copy link

github-actions bot commented Feb 25, 2025

Test Results

 22 files   -  1  314 suites   - 21   47m 45s ⏱️ - 15m 17s
617 tests  -  2  609 ✅ +  9  4 💤 ±0  4 ❌  - 11 
955 runs  +93  942 ✅ +103  8 💤 +4  5 ❌  - 14 

For more details on these failures, see this check.

Results for commit c1da700. ± Comparison against base commit 11c93ff.

This pull request removes 2 tests.
"before all" hook in "HBAR Rate Limit Tests" ‑ RPC Server Acceptance Tests Acceptance tests @hbarlimiter HBAR Limiter Acceptance Tests HBAR Rate Limit Tests "before all" hook in "HBAR Rate Limit Tests"
should execute "web3_client_version" ‑ RPC Server Acceptance Tests Acceptance tests @api-batch-2 RPC Server Acceptance Tests @release Hardcoded RPC Endpoints should execute "web3_client_version"

♻️ This comment has been updated with latest results.

quiet-node
quiet-node previously approved these changes Feb 26, 2025
Copy link
Member

@quiet-node quiet-node left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@quiet-node
Copy link
Member

Approved but however, we should also reach out to DAs to make sure this removal is not blocking anyone

@natanasow natanasow requested a review from a team February 26, 2025 15:12
acuarica
acuarica previously approved these changes Feb 27, 2025
Copy link
Contributor

@acuarica acuarica left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Out of curiosity, do we know why we added it in the first place?

@natanasow natanasow dismissed stale reviews from acuarica and quiet-node via c1da700 February 27, 2025 10:51
@natanasow
Copy link
Collaborator Author

Out of curiosity, do we know why we added it in the first place?

TBH I don't know. I tried to dig deeper but it was added a long time ago (September 2022) and I didn't find any clue.

Copy link

codecov bot commented Feb 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.53%. Comparing base (11c93ff) to head (c1da700).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3508      +/-   ##
==========================================
+ Coverage   85.43%   85.53%   +0.09%     
==========================================
  Files          69       69              
  Lines        4743     4741       -2     
  Branches     1000     1000              
==========================================
+ Hits         4052     4055       +3     
+ Misses        401      399       -2     
+ Partials      290      287       -3     
Flag Coverage Δ
config-service 95.16% <ø> (ø)
relay 79.53% <ø> (ø)
server 83.38% <ø> (+0.09%) ⬆️
ws-server 36.31% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...s/server/src/koaJsonRpc/lib/methodConfiguration.ts 100.00% <ø> (ø)
packages/server/src/server.ts 80.15% <ø> (-0.16%) ⬇️

... and 3 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Review duplication of web3_client_version and web3_clientVersion.
3 participants