Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Improve account blocklisting feature #463

Merged
merged 4 commits into from
Dec 15, 2023

Conversation

stefan-stefanooov
Copy link
Contributor

Description:
Add a method that reads the row from the csv file and add this number to the starting number for each type of account.

Related issue(s):
Improve account blocklisting feature#403

@stefan-stefanooov stefan-stefanooov linked an issue Dec 11, 2023 that may be closed by this pull request
@stefan-stefanooov stefan-stefanooov self-assigned this Dec 12, 2023
@stefan-stefanooov stefan-stefanooov added the Improvement Code changes driven by non business requirements. label Dec 12, 2023
@stefan-stefanooov stefan-stefanooov added this to the 2.21.0 milestone Dec 12, 2023
@stefan-stefanooov stefan-stefanooov force-pushed the 403-improve-account-blocklisting-feature branch from c309224 to a86ec14 Compare December 12, 2023 11:12
Copy link
Member

@georgi-l95 georgi-l95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice approach, it just needs a few corrections and should be ready to go

Signed-off-by: Stefan Stefanov <[email protected]>
Signed-off-by: Stefan Stefanov <[email protected]>
Copy link
Member

@georgi-l95 georgi-l95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG, Just a few nits and we'll be ready to go 👍

Signed-off-by: Stefan Stefanov <[email protected]>
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Member

@georgi-l95 georgi-l95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@georgi-l95 georgi-l95 modified the milestones: 2.21.0, 2.18.0 Dec 15, 2023
@georgi-l95 georgi-l95 merged commit ca7d5ed into main Dec 15, 2023
@georgi-l95 georgi-l95 deleted the 403-improve-account-blocklisting-feature branch December 15, 2023 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Improvement Code changes driven by non business requirements. Limechain
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve account blocklisting feature
2 participants