Add a bool field to allow fractional fee to be charged to sender or receiver. #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ljianghedera <[email protected]>
ljianghedera
requested review from
steven-sheehy,
qnswirlds,
tinker-michaelj,
anighanta and
abhishek-hedera
anighanta
previously approved these changes
Aug 4, 2021
qnswirlds
previously approved these changes
Aug 4, 2021
xin-hedera
suggested changes
Aug 4, 2021
src/main/proto/CustomFees.proto
Outdated
| @@ -34,6 +34,7 @@ message FractionalFee { | |||
| Fraction fractional_amount = 1; // The fraction of the transferred units to assess as a fee | |||
| int64 minimum_amount = 2; // The minimum amount to assess | |||
| int64 maximum_amount = 3; // The maximum amount to assess (zero implies no maximum) | |||
| bool netOfTransfers = 4; // If true, assesses the fee to the sender, so the receiver gets the full amount from the token transfer list, and the sender is charged an additional fee; if false, the receiver does NOT get the full amount, but only what is left over after paying the fractional fee | |||
Signed-off-by: ljianghedera <[email protected]>
nathanklick
deleted the
081-D-fractional-fee-charged-to-sender-or-receiver
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR adds one bool field to allow the user to decide the fractional custom fee to be charged to sender or receiver.
Related issue(s):
Fixes #81
Checklist