Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include support to enumerate verified contracts #138

Open
Tracked by #264
acuarica opened this issue Feb 28, 2024 · 3 comments
Open
Tracked by #264

Include support to enumerate verified contracts #138

acuarica opened this issue Feb 28, 2024 · 3 comments
Assignees
Labels
New Feature A new feature, service, or documentation. Major changes that are not backwards compatible. P3 Low priority issue. Will not impact the release schedule if not complete. question Further information is requested

Comments

@acuarica
Copy link
Contributor

acuarica commented Feb 28, 2024

It would be a good addition to add the possibility to enumerate verified contracts, both sorted and paginated. Currently the closest endpoint to do that is /files/contracts/{chain}. However this endpoint fetches all contracts, which is of no use without filtering, sorting and pagination.

After talking to @svienot, in order to support this feature we would need to add some sort of database that can be queried against.

Some verification specific information to include would be verification date/time and language. On-chain data would include TX creation.

As a reference, a couple of explorers support this feature, e.g.,

@acuarica acuarica added New Feature A new feature, service, or documentation. Major changes that are not backwards compatible. P3 Low priority issue. Will not impact the release schedule if not complete. question Further information is requested labels Feb 28, 2024
@acuarica acuarica self-assigned this Jun 10, 2024
@acuarica acuarica moved this to Tasks In Progress in Smart Contract Sprint Board Jun 10, 2024
@acuarica acuarica moved this from Tasks In Progress to Backlog in Smart Contract Sprint Board Jun 17, 2024
@Nana-EC
Copy link
Collaborator

Nana-EC commented Jul 12, 2024

@acuarica to update with dependency status

@acuarica
Copy link
Contributor Author

Currently the verified contracts are stored in the filesystem. This does not allow us for easy enumeration and querying of verified smart contracts.

The Sourcify team is working to replace the filesystem storage with a DB of verified contracts. Once the DB implementation is releases and stable, we can include it in our distribution and make queries against verified contracts.

@acuarica
Copy link
Contributor Author

The Sourcify team already implemented the DB of verified contracts as part of their v2 ethereum/sourcify#1545.

We need to now upgrade Sourcify on our side to implement this feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
New Feature A new feature, service, or documentation. Major changes that are not backwards compatible. P3 Low priority issue. Will not impact the release schedule if not complete. question Further information is requested
Projects
Status: Backlog
Development

No branches or pull requests

2 participants