From 47bbf001388ac47daca0957a02cab9204c84f39f Mon Sep 17 00:00:00 2001 From: Hristiyan Date: Tue, 21 Jan 2025 11:38:14 +0200 Subject: [PATCH] fix: unit tests Signed-off-by: Hristiyan --- .../transaction-status/transaction-status.service.spec.ts | 6 +++++- .../notifications/src/receiver/receiver.service.spec.ts | 6 +++++- 2 files changed, 10 insertions(+), 2 deletions(-) diff --git a/back-end/apps/chain/src/transaction-status/transaction-status.service.spec.ts b/back-end/apps/chain/src/transaction-status/transaction-status.service.spec.ts index 42cd0c9ee..97cd1b99a 100644 --- a/back-end/apps/chain/src/transaction-status/transaction-status.service.spec.ts +++ b/back-end/apps/chain/src/transaction-status/transaction-status.service.spec.ts @@ -15,6 +15,7 @@ import { notifySyncIndicators, notifyTransactionAction, notifyWaitingForSignatures, + getNetwork, } from '@app/common'; import { NotificationType, @@ -405,6 +406,7 @@ describe('TransactionStatusService', () => { creatorKey: { userId: 23, }, + mirrorNetwork: 'testnet', }; transactionRepo.findOne.mockResolvedValue(transaction as Transaction); @@ -413,6 +415,8 @@ describe('TransactionStatusService', () => { await service.updateTransactionStatus({ id: transaction.id }); + const networkString = getNetwork(transaction as Transaction); + expect(transactionRepo.update).toHaveBeenNthCalledWith( 1, { @@ -431,7 +435,7 @@ describe('TransactionStatusService', () => { entityId: transaction.id, type: NotificationType.TRANSACTION_READY_FOR_EXECUTION, actorId: null, - content: `Transaction ${transaction.transactionId} is ready for execution`, + content: `Transaction ${transaction.transactionId} on ${networkString} network is ready for execution!`, userIds: [transaction.creatorKey?.userId], }); expect(notifyTransactionAction).toHaveBeenCalledWith(notificationsService); diff --git a/back-end/apps/notifications/src/receiver/receiver.service.spec.ts b/back-end/apps/notifications/src/receiver/receiver.service.spec.ts index 61f5e4992..c85d4e8a5 100644 --- a/back-end/apps/notifications/src/receiver/receiver.service.spec.ts +++ b/back-end/apps/notifications/src/receiver/receiver.service.spec.ts @@ -7,6 +7,7 @@ import { MirrorNodeService, NotifyForTransactionDto, NotifyGeneralDto, + getNetwork, } from '@app/common'; import { Notification, @@ -648,6 +649,7 @@ describe('ReceiverService', () => { signedTransactions: [], createdTransactions: [], }, + mirrorNetwork: 'testnet', }; entityManager.findOne .calledWith(Transaction, expect.anything()) @@ -666,6 +668,8 @@ describe('ReceiverService', () => { await service.notifyTransactionRequiredSigners(dto); + const networkString = getNetwork(transaction as Transaction); + expect(entityManager.findOne).toHaveBeenCalledWith(Transaction, { where: { id: dto.transactionId }, relations: { creatorKey: true }, @@ -674,7 +678,7 @@ describe('ReceiverService', () => { expect(notifyGeneral).toHaveBeenCalledWith({ userIds: usersIdsRequiredToSign.filter(id => id !== creatorId), type: NotificationType.TRANSACTION_WAITING_FOR_SIGNATURES, - content: `A new transaction requires your review and signature. Please visit the Hedera Transaction Tool and locate the transaction using the following ID: ${transaction.transactionId}.`, + content: `A new transaction submitted on ${networkString} network requires your review and signature. Please visit the Hedera Transaction Tool and locate the transaction using the following ID: ${transaction.transactionId}.`, entityId: 1, actorId: null, });