chore: add eslint-plugin-playwright rules for e2e tests and fix errors
#2680
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
hashicc
commented
Feb 4, 2025
hashicc
changed the title
eslint-plugin-playwright rule for e2e tests and fix errorseslint-plugin-playwright rules for e2e tests and fix errors
hashicc
changed the title
eslint-plugin-playwright rules for e2e tests and fix errorseslint-plugin-playwright rules for e2e tests and fix errors
moduli
approved these changes
Feb 11, 2025
ZedLi
approved these changes
Feb 11, 2025
DhariniJeeva
approved these changes
Feb 12, 2025
* fix errors related to playwright/valid-describe-callback rule
hashicc
force-pushed
the
hashicc/eslint-playwright
branch
from
f28534f to
feb922f
Compare
|
None blocking comment: When running |
calcaide
approved these changes
Feb 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This prs adds the
eslint-plugin-playwrighteslint rule with the recommended rules applied.There are 110 new warnings reported, most of which are either:
Avoid having conditionals in tests (playwright/no-conditional-in-test)Test has no assertions (playwright/expect-expect)We could:
I think these are good warnings to have though so I'd recommend either option 1. or 2.
How to Test
asyncto a describe block callbackyarn lintand/or within the editorChecklist
- [ ] I have added before and after screenshots for UI changes- [ ] I have added JSON response output for API changes- [ ] I have added steps to reproduce and test for bug fixes in the description- [ ] I have commented on my code, particularly in hard-to-understand areas- [ ] I have added tests that prove my fix is effective or that my feature works