Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for a container image #69

Open
remyleone opened this issue Oct 17, 2023 · 2 comments
Open

Add support for a container image #69

remyleone opened this issue Oct 17, 2023 · 2 comments
Labels
enhancement New feature or request

Comments

@remyleone
Copy link

It would be helpful to run this program in a CI. Having a OCI image for it would be helpful :)

@austinvalle austinvalle added the enhancement New feature or request label Oct 17, 2023
@bflad
Copy link
Contributor

bflad commented Oct 17, 2023

Hi @remyleone 👋

Can you walk through why a container is important for your CI workflow over standard Go buildchain tooling? Another consideration is that https://github.com/hashicorp/terraform-plugin-codegen-openapi would likely be separate in this model, since it has its own releases and use cases (as developers can bring in or make their own different spec source generators).

More commonly, we would anticipate that this Go module’s dependency would be tracked within another Go module (e.g. the provider codebase or a “tools” sub-module). At that point, it is a matter of go install github.com/hashicorp/terraform-plugin-codegen-framework/cmd/tfcodegen-framework so the CLI is installed with the declared version. Even without declaring the dependency in that manner, go install can still be used with @... appended with the latest keyword or a particular version tag. It's even possible to go run directly in many cases, where Go handles all the install and execution details.

Thanks!

@remyleone
Copy link
Author

At the moment we handle most of our code generation using containers because they mix different languages and different toolchain (mostly protobuf). Therefore we handle most of our code generation in a CI pipeline with dedicated containers for each targets. I'm hoping that the next version of golang will bring improve support for tooling. If that would be the case then yes I would do the tfgen calls from the native golang toolchain.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants