Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Terraform validator: skip google_compute_instance boot disk verification for unconfigured provider #8489

Closed
melinath opened this issue Feb 17, 2021 · 3 comments
Labels
Milestone

Comments

@melinath
Copy link
Collaborator

Terraform validator supports an "offline" mode which purposely does not configure the provider for GCP access. However, the expandBootDisk function for compute_instance assumes that the provider is configured for GCP access. We should silently skip this verification (at least when offline), because terraform validator is not responsible for validating that the configuration is correct, just that it complies with policies.

This is somewhat complicated by the fact that expandBootDisk is currently manually "shared" between terraform-provider-google and terraform-google-conversion (i.e. copy-pasted from one to the other.)

melinath added a commit to GoogleCloudPlatform/terraform-validator that referenced this issue Feb 17, 2021
@rileykarson rileykarson added this to the Goals milestone Feb 22, 2021
@melinath
Copy link
Collaborator Author

Possibly related: GoogleCloudPlatform/terraform-validator#89

@melinath
Copy link
Collaborator Author

Closing as a duplicate of the above issue.

@github-actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 24, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants