New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unreachable branch in splitsAt #114

Open

qrpnxz opened this issue Jul 23, 2022 · 1 comment

Labels

qrpnxz commented Jul 23, 2022

streaming/src/Streaming/Internal.hs

Lines 703 to 708 in 0721e4b

    
           | n <= 0    = Return stream 
        
           | otherwise = case stream of 
        
               Return r -> Return (Return r) 
        
               Effect m -> Effect (fmap (loop n) m) 
        
               Step fs  -> case n of 
        
                 0 -> Return (Step fs)

This last line looks unreachable.

Member

chessai commented Apr 23, 2023

Good catch!
That 0 -> Return (Step fs) line should just be removed.

chessai added the enhancement label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment