-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reconsider name of zipsWith' #15
Comments
Ideas:
I'm not crazy about any of them though. Also, I just remembered that the haddocks for that function will need to be adjusted to put the |
We'd best verify the rest of the laws.
…On Sep 13, 2017 3:07 PM, "Andrew Martin" ***@***.***> wrote:
Ideas:
- zipsLayerWith
- zipsLayer
- zipsFunctor
I'm not crazy about any of them though. Also, I just remembered that the
haddocks for that function will need to be adjusted to put the MonadPlus
laws in a code block.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#15 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABzi_XhxfO27YehWzDTxz6ijjdOp0qYfks5siCflgaJpZM4PWglL>
.
|
As a look at it more, I realize that I don't understand what is meant by "satisfying the MonadPlus laws" in this context. After all, |
Look at the Alternative instance. But laws aside, the previous behavior
seemed perverse.
…On Sep 13, 2017 3:59 PM, "Andrew Martin" ***@***.***> wrote:
As a look at it more, I realize that I don't understand what is meant by
"satisfying the MonadPlus laws" in this context. After all, zipsWith' is
just a function. Why does it need to satisfy any laws. Isn't the onus for
that usually on the definitions of mzero and mplus, not on other
functions?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#15 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABzi_XHRFi9y4Vzecex-A4y8-EeFHjeCks5siDQJgaJpZM4PWglL>
.
|
Actually, the rest of the laws seem fairly clearly okay, although proving
that would require explicitly stating what our equivalence is. And I agree
with @michaelt that the Alternative instance he came up with (with just the
one correction) is the only one that makes any sense.
…On Sep 13, 2017 3:19 PM, "David Feuer" ***@***.***> wrote:
We'd best verify the rest of the laws.
On Sep 13, 2017 3:07 PM, "Andrew Martin" ***@***.***> wrote:
> Ideas:
>
> - zipsLayerWith
> - zipsLayer
> - zipsFunctor
>
> I'm not crazy about any of them though. Also, I just remembered that the
> haddocks for that function will need to be adjusted to put the MonadPlus
> laws in a code block.
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub
> <#15 (comment)>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/ABzi_XhxfO27YehWzDTxz6ijjdOp0qYfks5siCflgaJpZM4PWglL>
> .
>
|
We should also reconsider the names of all the functions currently flagged |
I was hoping someone would come up with a better name before that PR got merged.
The text was updated successfully, but these errors were encountered: