Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge happy-* library packages into a single happy library component (#292) #293

Closed
wants to merge 1 commit into from
Closed

Merge happy-* library packages into a single happy library component (#292) #293

wants to merge 1 commit into from

Conversation

sgraf812
Copy link
Collaborator

See #292. Fixes #292.

I'm delighted that git is able to map the renamings, which should make this PR easy to review.

@sgraf812 sgraf812 requested a review from int-index September 13, 2024 14:06
Ericson2314
Ericson2314 requested changes Sep 13, 2024
View reviewed changes
Copy link
Collaborator

@Ericson2314 Ericson2314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really do not like this. If the modular boundaries are not enforced, everything will bleed back together. Humans cannot be trusted to manually enforce boundaries during code review, the computer must help.

Does multi-repl not solve all the annoyances of having multiple libraries?

@Ericson2314 Ericson2314 mentioned this pull request Sep 13, 2024
Closed
@int-index
Copy link
Collaborator

int-index commented Sep 13, 2024 •
edited
Loading

This is a good change because it removes lots of administrative overhead. @Ericson2314's concern is valid, but given the lack of resources to maintain happy I find it justified to prioritize ease of maintenance, release management, etc, over enforcing module boundaries.

@Bodigrim's suggestion in #288 (comment) could be a viable alternative, too. Either way, we need to get rid of those separate .cabal files.

@sgraf812
Copy link
Collaborator Author

Closed in favor of #297.

@sgraf812 sgraf812 closed this Sep 15, 2024
@sgraf812 sgraf812 deleted the wip/T292 branch September 15, 2024 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ericson2314 Ericson2314 Ericson2314 requested changes

@int-index int-index Awaiting requested review from int-index

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Merge happy-* library packages into a single happy library component
3 participants
@sgraf812 @int-index @Ericson2314