Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Happy 2.1 broke fortran-src #324

Closed
sgraf812 opened this issue Oct 21, 2024 · 2 comments
Closed

Happy 2.1 broke fortran-src #324

sgraf812 opened this issue Oct 21, 2024 · 2 comments

Comments

@sgraf812
Copy link
Collaborator

See camfort/fortran-src#293. I tried reproducing the issue with 2.0.2 but failed to do so. I have an idea what has gone wrong: The error indicates that the Lexer emits a token that was not announced to happy via a %token declaration. Rather than panicking we should simply emit a parse error, like we used to (I think).

@sgraf812
Copy link
Collaborator Author

sgraf812 commented Oct 21, 2024

Hmm. Strangely I couldn't reproduce the issue with 2.1 either.

Anyway, I got rid of the error call that caused camfort/fortran-src#293 in #322, so we should be good after it lands.

Try the package candidate with the following cabal.project:

packages:
  .
  http://hackage.haskell.org/package/happy-lib-2.1.1/candidate/happy-lib-2.1.1.tar.gz
  http://hackage.haskell.org/package/happy-2.1.1/candidate/happy-2.1.1.tar.gz

@sgraf812
Copy link
Collaborator Author

sgraf812 commented Oct 23, 2024

#320 landed. Fixed in Happy 2.1.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant