Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add indexed maps and traversals #145

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

treeowl
Copy link
Collaborator

@treeowl treeowl commented Apr 23, 2018

  • Add indexed maps (lazy and strict) and traversals (general and
    PrimMonad-specialized) for Array and SmallArray to match
    the ones in PrimArray.

  • Add some missing @since annotations.

* Add indexed maps (lazy and strict) and traversals (general and
  `PrimMonad`-specialized) for `Array` and `SmallArray` to match
  the ones in `PrimArray`.

* Add some missing `@since` annotations.
@treeowl
Copy link
Collaborator Author

treeowl commented Apr 23, 2018

@andrewthad, do these look okay to you?

@andrewthad
Copy link
Collaborator

It could use some tests like the test for mapArray'. One of the property tests you'll want is named imapMProp instead of itraverseProp.

The since annotations seem too high. Should they not be 0.6.4.0 instead of 0.6.4.1?

@cartazio
Copy link
Contributor

cartazio commented Mar 6, 2020

lets circle back on theses and a few others over the course of march/april (i'm round robin catching up on everything)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants