Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new step Signature that will format function signatures #350

Draft
wants to merge 11 commits into
base: main
Choose a base branch
from
Draft

Add new step Signature that will format function signatures #350

wants to merge 11 commits into from

Commits on Apr 9, 2021

  1. Add new step Signature that will format function signatures 

    The step is a NOP still but additional tests were already created
specifing how we anticipate the step to behave. This step is heavily
inspired by https://github.com/input-output-hk/ouroboros-network/blob/bf8579cc2ff2a7bc4ba23150eff659cfd1c6ccca/ouroboros-consensus/docs/StyleGuide.md
    @EncodePanda
    EncodePanda committed Apr 9, 2021
    Configuration menu
    Copy the full SHA
    9b36847 View commit details
    Browse the repository at this point in the history

  2. Modify Signature to look top level func signatures and prepare for fo… 

    …rmatting
    @EncodePanda
    EncodePanda committed Apr 9, 2021
    Configuration menu
    Copy the full SHA
    b30c944 View commit details
    Browse the repository at this point in the history

  3. Add noop change function

    @EncodePanda
    EncodePanda committed Apr 9, 2021
    Configuration menu
    Copy the full SHA
    d66228d View commit details
    Browse the repository at this point in the history

  4. Add getEndColumnUnsafe for a given Located element

    @EncodePanda
    EncodePanda committed Apr 9, 2021
    Configuration menu
    Copy the full SHA
    0bd9851 View commit details
    Browse the repository at this point in the history

  5. Implement test case 'wrap signature if it does not fit max column len… 

    …gth'
    @EncodePanda
    EncodePanda committed Apr 9, 2021
    Configuration menu
    Copy the full SHA
    53f6d6c View commit details
    Browse the repository at this point in the history

  6. Extract printDecl to separate toplevel function

    @EncodePanda
    EncodePanda committed Apr 9, 2021
    Configuration menu
    Copy the full SHA
    0497835 View commit details
    Browse the repository at this point in the history

  7. Extract helper printing functions

    @EncodePanda
    EncodePanda committed Apr 9, 2021
    Configuration menu
    Copy the full SHA
    d9ccfdb View commit details
    Browse the repository at this point in the history

  8. Simplify formatSignatureDecl

    @EncodePanda
    EncodePanda committed Apr 9, 2021
    Configuration menu
    Copy the full SHA
    ce99839 View commit details
    Browse the repository at this point in the history

  9. Simplify access to SignatureDecl inside printDecl

    @EncodePanda
    EncodePanda committed Apr 9, 2021
    Configuration menu
    Copy the full SHA
    f331870 View commit details
    Browse the repository at this point in the history

  10. Extract printRemainingLine function

    @EncodePanda
    EncodePanda committed Apr 9, 2021
    Configuration menu
    Copy the full SHA
    63e3bbf View commit details
    Browse the repository at this point in the history

  11. Implement "how it behaves when there is a list of constraints"

    @EncodePanda
    EncodePanda committed Apr 9, 2021
    Configuration menu
    Copy the full SHA
    41ca2df View commit details
    Browse the repository at this point in the history