Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support ghc 9.12 #97

Open
erikd opened this issue Dec 10, 2024 · 5 comments
Open

Support ghc 9.12 #97

erikd opened this issue Dec 10, 2024 · 5 comments

Comments

@erikd
Copy link

erikd commented Dec 10, 2024

No description provided.

@ulysses4ever
Copy link

Yes, please!

@phadej
Copy link
Collaborator

phadej commented Dec 19, 2024

Yes, please!

I say it one more time, pinging on this kind of issues is tiresome. I have dozens of packages, and individual pings (or to be fair, opening issues to begin with for packages in dependency closure of aeson / lens) are not helpful at all. I'm aware that GHC-9.12.1 just got released.

The spam simply makes me ignore the issues.

I will update the CONTRIBUTING.md to actually forbid opening the issues at all until the GHC release had been around for few months.

@ulysses4ever
Copy link

Sorry about that 😞 I actually was under impression that you did support people opening issues as opposed to PRs: I can sware I saw such a comment, but of course I can't find it now. Good to know you don't.

I'm also unsure what policy goes for packages not under your personal account (e.g. haskellari /= phadej). So, having a contributors guide is a good idea.

Better yet would be to add an issue template that would inform the author about the ban on issues around the latest GHCs... That would be the most direct and hence the most effective way to make sure you don't get these.

@phadej
Copy link
Collaborator

phadej commented Dec 19, 2024

I actually was under impression that you did support people opening issues as opposed to PRs: I can sware I saw such a comment, but of course I can't find it now. Good to know you don't.

The PRs are even less helpful, those I simply ignore. it's too much work to correct them than to do myself; no amount of documentation of what I want to see will make it work - the patches are so simple that one missing part makes them worthless. Either I'll fix them myself (which is the same as doing from scratch) or wait unknown amount of time for the contributor to fix them.

The idea with opening issues is for people to have a link to reference elsewhere. But I don't think @erikd references them anywhere. For him it might be helpful as he sees all of these issues in his open issues list, but nobody else benefits from these as far as I can tell. In comparison to e.g. issues like agda/agda#7574 referencing further issues. These kind of downstream issues give some motivation: I see what is blocked on me. Again, I don't see this issue blocking anything (I have an idea, e.g. cabal-install tests - but it's my prior knowledge which I might forget, and maybe there's some bigger blocker anyway).

I'm also unsure what policy goes for packages not under your personal account

The CONTRIBUTING.md is there everywhere.

Better yet would be to add an issue template

That's an idea, I have to test that.


TL;DR trivial and repetitive issues waste my time.

@erikd
Copy link
Author

erikd commented Dec 20, 2024

But I don't think @erikd references them anywhere

I do. They are in an issue in an IOG private Git repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants