Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull curator from source and drop patch #1

Open
chreekat opened this issue Apr 19, 2024 · 5 comments
Open

Pull curator from source and drop patch #1

chreekat opened this issue Apr 19, 2024 · 5 comments

Comments

@chreekat
Copy link
Member

chreekat commented Apr 19, 2024

/stackage-builder/curator_hackage-server-T1023.patch

@juhp
Copy link

juhp commented Oct 23, 2024

Where/how is it used btw?

@chreekat
Copy link
Member Author

I used the patch in flake.nix, where I define the precise version of curator that gets deployed on the server. I had pinned the curator repo to whatever revision master pointed to at the time I started working on it.

My patch was merged upstream, so we just need to update the pin and drop the patch.

@chreekat
Copy link
Member Author

@juhp
Copy link

juhp commented Oct 25, 2024

Okay, I guess my question is what do you actually use/need curator for?

We pull the curator binary directly for building snapshots.
So maybe you just used it for testing etc?

@chreekat
Copy link
Member Author

That's a great question. But it turns out there's a good answer. (I had to just double check :D )

The reason is that the curator repo is the source of both curator and casa-curator. The latter is actually what got patched. It runs as a background process on the server, keeping casa up to date.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants