Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use secrets.stencil.json rather than creating a new access token file #12

Open
joeyhoer opened this issue Aug 19, 2024 · 0 comments
Open

Comments

@joeyhoer
Copy link

This setting could perhaps be optional. It seems redundant to add an accessToken to each widget configuration when one is already present in the theme secrets.stencil.json file.

This issue may be specific to how we organize themes. We typically store widget code in a widgets directory within the stencil theme.

theme/
└── widgets/
    └── widget/

If such a directory structure is used, then that accessToken can be used for all widgets.

Perhaps a separate, though related, feature suggestion is to add the apiPath value to the config.stencil.json file rather than adding that to another file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant