Verify if Spring Data Hazelcast works fine with ReactiveCrudRepository

[neilstevenson]

Investigate & support org.springframework.data.repository.reactive.ReactiveCrudRepository

[neilstevenson]

See Spring Data Keyvalue - 2.0

[leszko]

I think our Spring Data Hazelcast should work fine with ReactiveCrudRepository. Let's keep this GH issue just as verification.

[pjrowe89]

What is the status of this issue?

[leszko]

I think nobody verified it yet. If someone does and it works, please write a comment here and close this issue.

[pangeran-bottor]

Hello. After discussing with @Holmistr, I would like to work on this

[Holmistr]

Hi @pangeran-bottor ! And the issue is yours! 🎉 Shortly, our experts will provide you some guidance, entry points. Looking forward to your contribution by reviewing this!

[leszko]

@pangeran-bottor , thanks a lot for volunteering to take this GH Issue.

As the verification, the best starting point would be just to use spring-data-hazelcast and check if it works with all the features of ReactiveCrudRepository. And:

• if it works => Send a PR with the Integration Test for that
• if it doesn't work => Check what's wrong and either create a fix or create a new GH issue

If you have a any questions, you can ask here directly. I'll try to help :)

[pangeran-bottor]

Noted, thanks @leszko

[Holmistr]

Hi @pangeran-bottor , just checking in - is there anything we can help you out with? I just want to make sure that you're not stuck on something and just afraid to ask :)

[pangeran-bottor]

Hi @Holmistr @leszko, my intention before was to mimick CrudIT test class and change the repository to ReactiveCrudRepository but turned out we can't extends it (e.g public interface PersonRepository extends ReactiveCrudRepository<Person, String>), seems I misunderstood the starting point :)
Could you provide a raw flow on how to test this?

[pivovarit]

Well, the testing is fairly easy - once you have the implementation ready, you wire the whole thing up and execute public methods from the repository that extends ReactiveCrudRepository.

But I see a different issue here - HazelcastRepository extends KeyValueRepository which is a spring-data-keyvalue artifact. So I'd start by searching for spring-data-keyvalue reactive support

[Holmistr]

@pangeran-bottor As per our private discussion, I'm unassigning you the issue for now. Thank you very much for looking into it and we would be happy to see you taking another one!