Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No stepsize here. #1

Open
foTok opened this issue Sep 25, 2018 · 1 comment
Open

No stepsize here. #1

foTok opened this issue Sep 25, 2018 · 1 comment

Comments

@foTok
Copy link

foTok commented Sep 25, 2018

if ((self.tank_1 + self.tank_2 + self.tank_LA) >= 10 and (self.tank_3 + self.tank_4 + self.tank_RA) >= 10):

Hi, if you just set the threshold as 10, I think it means that we just simulate 1 time step. However, in the following code, you added step size to simulate how fuel flows between tanks. By default, "stepsize=1", I think the program works well. But I am afraid if you set stepsize as some values else, there would be problem.

@hazrmard
Copy link
Owner

Good catch. I patched that issue (by scaling standard demand of 10 by the stepsize) and added some comments explaining the model in commit b46ee64.

You can pull the repo to apply those changes. Or simply copy-paste the models/fuel_tanks.py file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants