Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Completed Base Requirements! #1

Open
hdahme opened this issue Apr 1, 2014 · 3 comments
Open

Completed Base Requirements! #1

hdahme opened this issue Apr 1, 2014 · 3 comments

Comments

@hdahme
Copy link
Owner

hdahme commented Apr 1, 2014

Hey @nesquena !

The base requirements for this task are completed. I'll work away on styling it more, and on sqlite offine storage stuff, I didn't get as much time to work on it this weekend as I would have liked, travelling and all. I just want to get the base submission in before the deadline

Cheers

@nesquena
Copy link

nesquena commented Apr 2, 2014

👍 decent work Harrison although as you said pretty bare. A few notes after checking out the code:

  • Consider cleaning up your timestamp to display relative time (i.e 3 mins ago)
  • Consider adding pull to refresh for the home timeline as explained in the cliffnotes page
  • Good to see you added the tweet to the home timeline after you posted new on compose
  • Consider adding the character count for Compose Activity to limit to 140. See this event handler for more details.
  • Consider removing BaseModel from Tweet and User and follow this json to model approach instead which doesn't require BaseModel
  • Consider adding ActiveAndroid to the Tweet and User. See the persistence guide and this other guide for more details.

Here's a detailed Project 3 Feedback Guide here which covers the most common issues with this submitted project. Read through the feedback guide point-by-point to determine how you could improve your submission.

Let us know if you have any other thoughts or questions about this assignment. Hopefully by now you feel pretty comfortable with all the major pieces to basic Android apps (Views, Controllers, Models, Authentication, API Communication, Preferences, ActionBar, et al) and see how they all fit together. We are close to a turning point in the course where you should be hitting a "critical mass" for your Android knowledge.

@hdahme
Copy link
Owner Author

hdahme commented Apr 8, 2014

Hey @nesquena !

I've completed the required user stories for this week, and took into account some of the feedback you gave me last week (Thanks 😄 )

@nesquena
Copy link

nesquena commented Apr 8, 2014

Decent work overall. A few notes after checking out the code:

  • In the future, definitely consider additional polish for the UI by reviewing the cloning a screen tutorial and Q&A and the drawables guide.
  • Consider adding progress bars to your app whenever a network request goes out
  • For tabs, try following this approach for cleaner tab listeners and better memory management.
  • For a future exercise, challenge yourself to move even more of the logic into the base Fragment class and out of the extension timeline fragments. For example, the scroll listener could be set in the base class and then the "onLoadMore" could call an abstract method which is defined separately in the extended class. This approach could be used to move almost all the logic into the base except for certain key abstract methods.
  • Incomplete: I'm pretty sure endless pagination is totally broken in this version...I don't see anywhere that you've implemented working pagination for any timelines in the client? Can you please address this?

Here's a detailed Project 4 Feedback Guide here which covers the most common issues with this submitted project. Read through the feedback guide point-by-point to determine how you might be able to improve your submission.

This week (Week 5), we are going to cover the last major piece to the Android puzzle and that is using the hardware and SDK components such as the camera, photo gallery, location, maps, etc. After that, Week 6 and week 7 we will be covering a few important intermediate topics such as more about styling and animation as well as testing.

Following the bootcamp (May 12th), we are going to have a demo day to celebrate the progress you've all made with our next batch of Android students and multiple companies attending to see the group projects that you all have built. We are going to help however we can over the next few weeks to get the team project apps in shape for that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants