Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[console] DrupalCommand annotation fails when $extension_type is equal to "profile" #4119

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[console] DrupalCommand annotation fails when $extension_type is equal to "profile" #4119

wants to merge 1 commit into from

Conversation

frodri
Copy link

@frodri frodri commented Jul 31, 2019 •
edited
Loading

Problem/Motivation

Generated commands on an install profile are unable to run due to the DrupalCommand failing whenever $extension_type is set to "profile".

How to reproduce

  • Drupal version: 8.7.1
  • Console version: 1.8.0
  • Create a custom installation profile and install it on a site.
  • Generate a new Drupal Console command. (drupal gco --extension="my-new-profile" --extension-type="profile" --class="DefaultCommand" --name="DefaultCommandName")
  • Run the command.

Solution

  • Change Drupal\Console\Extension\Manager to properly detect the currently installed site profile.
  • Implement addResourceTranslationsByProfile() on Drupal\Console\Utils\TranslationManager.

@frodri frodri changed the title [ console] DrupalCommand annotation fails when $extension_type is equal to "profile" [console] DrupalCommand annotation fails when $extension_type is equal to "profile" Jul 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@frodri