Register InlineValuesProvider to get the frame id #170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ono-max
commented
Dec 7, 2022
| @@ -7,7 +7,7 @@ | |||
| "version": "2.4.0", | |||
| "license": "GPL-3.0", | |||
| "engines": { | |||
| "vscode": "^1.46.0" | |||
| "vscode": "^1.55.0" | |||
There was a problem hiding this comment.
We need to upgrade the version of vscode since InlineValuesProvider is not introduced in "1.46.0".
|
Could you take a look at this PR when having time? Thank you. |
|
Fixed in b66c30b - which uses a cleaner approach. Sorry for the delay! But thanks for raising the idea of using |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #169.
I could not confirm that this change worked in 904d006 since
yarn buildfailed. However, I could confirm that this change worked before it when I experimented in Ruby script.