💻 Realtime updates #4646
Assignees
Comments
|
I have quite some experiencing with implementing Soketi websockets in a project. Please let me know if you need any help! |
mergify bot
pushed a commit
that referenced
this issue
Dec 5, 2023
… time (#4812) Fixes #4804 **Problem** 1. The main issue spawns from having the _username_ as the partion_key for the invitations table, thereby preventing adding multiple invitations for the same user. 2. Also, even if this worked, users currently only see one invitation at the time; due to restricting messages to be 0 or 1. _This is now changed as well._ 3. There are a couple of things in the code that are inconsistent; e.g., https://github.com/hedyorg/hedy/blob/main/website/database.py#L737-L738 would remove _an invitation_ of the username, while the function name implies deleting an invitation to some class! **Solution** - create a unique, partition_key `username#class_id` in the INVITATIONS table. - with two independent indexes: `username` and `class_id` - allow second teachers (perhaps students later on as well!) to accept more than one invitation at the same time. - The reason we have messages in the session is mainly to display a number indicator in the profile dropdown menu. Logically, this should happen whenever teachers invite other users and these invitees do not have to reload the page to see the indicator, but now they do! - this should be fixed when we have realtime updates #4646! **How to test?** Follow the steps that Rico listed in #4804.
|
Hi @hasan-sh! I know we have now done this in some places (creating adventures) but I am not sure where else. It is totally ok if you leave this one, but can you make a list here of places where it needs to be done still, to ease handover? |
|
Hi @Annelein! Can you pick this up for the /admin page? |
|
Awesome, thanks!!
Love your proactive spirit, thanks! Sounds like a great idea to make this list, we can then prioritize in a next meeting. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Idea incl level
Currently, whenever the user makes an action, we mostly "reload" the page or redirect them. However, this isn't the best UX. For instance, removing a class, student and an adventure isn't reflected in the UI of all parties.
Additional context
This is problematic when different parties make changes simultaniously; e.g., after allowing second teachers to make changes (#4644). Use socketio or something similar.
The text was updated successfully, but these errors were encountered: