Skip to content
This repository has been archived by the owner on Oct 17, 2024. It is now read-only.

client shouldn't log 504 (timeout) errors when calling watch on the server api. #78

Open
tealeg opened this issue Feb 12, 2019 · 0 comments
Labels
feature request Request a new feature good first issue Good for newcomers
Milestone

Comments

@tealeg
Copy link
Contributor

tealeg commented Feb 12, 2019

The watch function will generally timeout if nothing changes for a particular prefix (by default this will happen after 30 seconds). The client code doesn't handle the 504 explicitly (it does handle timeouts in its own context), and thus it ends up logging all the timeouts, which is annoying and misleading.

We should make it simply ignore those timeouts, or perhaps just log them at DEUG level.

@tealeg tealeg added good first issue Good for newcomers feature request Request a new feature labels Feb 12, 2019
@asdine asdine added this to the v0.6.0 milestone Feb 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature request Request a new feature good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants