Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev-Loop fails when fullBuild does execute compiler:compile #1018

Open
romain-grecourt opened this issue Feb 9, 2024 · 0 comments
Open

Dev-Loop fails when fullBuild does execute compiler:compile #1018

romain-grecourt opened this issue Feb 9, 2024 · 0 comments
Labels
Milestone

Comments

@romain-grecourt
Copy link
Contributor

Version: 4.0.2


If the helidon-cli-maven-plugin is configured to have a life-cycle for the full build that does not include compiler:compile then the dev-loop fails with:

loop failed helidon-cli-maven-plugin must be configured as an extension

See MavenProjectSupplier.

TLDR: the dev-loop relies on a mechanism (MavenLifecycleParticipant) that only works within Maven extensions. It uses the event of compiler:compile (see MavenProjectConfigCollector) to determine that the helidon-cli-maven-plugin is configured as an extension.


Steps to reproduce:

Configure the helidon-cli-maven-plugin like this:

<plugin>
    <groupId>io.helidon.build-tools</groupId>
    <artifactId>helidon-cli-maven-plugin</artifactId>
    <extensions>true</extensions>
    <configuration>
        <devLoop>
            <fullBuild>
                <phase>generate-resources</phase>
            </fullBuild>
        </devLoop>
    </configuration>
</plugin>

Run helidon dev.


Possible ways to fix this:

  • Update the extension validation logic to be independent of the lifecycle configuration. I.e. simply validate that we can observe build events
  • Resolve the executions in the full build life-cycle and assert them instead of hard-coding compiler:compile.
@romain-grecourt romain-grecourt added this to the 4.0.6 milestone Feb 9, 2024
@romain-grecourt romain-grecourt modified the milestones: 4.0.6, 4.0.7 Mar 12, 2024
@romain-grecourt romain-grecourt modified the milestones: 4.0.7, 4.0.8, 4.0.10 Jul 30, 2024
@romain-grecourt romain-grecourt modified the milestones: 4.0.10, 4.0.11, 4.0.12 Aug 19, 2024
@romain-grecourt romain-grecourt modified the milestones: 4.0.12, 4.0.13, 4.0.14 Oct 2, 2024
@romain-grecourt romain-grecourt modified the milestones: 4.0.14, 4.0.15 Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant