Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: Can Helidon examples moved to a separate repository? #1854

Closed
ksurendra opened this issue May 22, 2020 · 3 comments
Closed

Enhancement: Can Helidon examples moved to a separate repository? #1854

ksurendra opened this issue May 22, 2020 · 3 comments
Assignees
Labels
3.x Issues for 3.x version branch defer enhancement New feature or request examples P2
Milestone

Comments

@ksurendra
Copy link
Contributor

Can Helidon examples moved to a separate repository so the platform "core" is seprate

Why?

  1. This will be helpful for contributors to submit PR's. As of now we have to FORK the entire repo with core and examples.
  2. Merging to a respective folder may become simpler

Challenges:

  1. Most examples depend on parent pom's, moving them out to separate folder may pose challenges with build failures.
  2. Standalone examples like helidon-standalone-quickstart-mp will work fine.

This will be helpful for contributors

@romain-grecourt romain-grecourt added examples enhancement New feature or request labels May 27, 2020
@romain-grecourt
Copy link
Contributor

This is something that we do have in scope.

Currently the examples that inherit an "application parent pom" must reference it using <relativePath> and indeed these examples cannot be moved or extracted as-is without updating the <relativePath>.

If we do move the examples, the development work will have to be carried out in branches where the version is a SNAPSHOT version for the corresponding Helidon version. Building the examples will still requires a local build of Helidon unless we deploy SNAPSHOT regularly to a remote maven repository (also in scope).

Tags will offer fully functional examples, each of them being properly self-contained.
We can decide to merge the latest tag in master in and do the development work in branches named "dev" and "1.x".

@ksurendra
Copy link
Contributor Author

I agree @romain-grecourt (and i've also noted some challenges). This was an observation and can be a back-burner and can be addressed when this may become a problem as Helidon platform/community grows.

@romain-grecourt romain-grecourt added this to the 2.0.1 milestone Jun 20, 2020
@m0mus m0mus modified the milestones: 2.0.1, 2.0.2 Jun 29, 2020
@m0mus m0mus modified the milestones: 2.0.2, 2.2.0, 2.1.1 Nov 12, 2020
@romain-grecourt romain-grecourt added this to the 3.0.0 milestone Feb 1, 2021
@m0mus m0mus added the P2 label Aug 30, 2021
@m0mus m0mus added the 3.x Issues for 3.x version branch label Aug 30, 2021
@tomas-langer tomas-langer removed their assignment May 19, 2022
@m0mus m0mus added the defer label Jun 1, 2022
@barchetta barchetta modified the milestones: 3.0.0, 4.0.0, 4.0.0-M1 Jan 23, 2023
@barchetta barchetta modified the milestones: 4.0.0-M1, 4.0.0-M2 Mar 13, 2023
@barchetta barchetta modified the milestones: 4.0.0-M1, 3.2.1, 3.2.2 Apr 18, 2023
@barchetta barchetta removed this from the 3.2.2 milestone Jun 26, 2023
@barchetta barchetta added this to the 3.2.7 milestone Feb 29, 2024
@barchetta
Copy link
Member

This has been completed for Helidon 3. After a little soak time we will do it for Helidon 4.

We will use #5887 to track work for Helidon 4

@m0mus m0mus added this to Backlog Aug 12, 2024
@m0mus m0mus moved this to Closed in Backlog Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.x Issues for 3.x version branch defer enhancement New feature or request examples P2
Projects
Archived in project
Development

No branches or pull requests

5 participants