-
Notifications
You must be signed in to change notification settings - Fork 566
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace db password placeholder in application.yaml for MP with value fetched from OCI vault secret. #4191
Comments
I have created a sample Helidon MP application that uses Custom Config Source and Oci Vault in https://github.com/klustria/helidon-mp-custom-config-oci-vault. The project is well documented so hopefully it provides answer to this issue. |
Project https://github.com/klustria/helidon-mp-custom-config-oci-vault is updated to provide commented out sample of getSecretBundleByName() usage if that is the preferred way. |
New update was pushed into the project https://github.com/klustria/helidon-mp-custom-config-oci-vault to simplify config parsing of the oci parameters from within the custom config source. Please pull the latest update. |
Please provide update, i.e. let me know if this solves your issue so I can close it. |
it worked well. one suggestion was given by one of my team member if we can incorporate those changes. "With the current implementation, following limitations are observed due to which module cannot be re-used as dependencies in other services:
Desirable Way: Able to use the secret-name directly against property, similar to using ENV variable I think with below changes it can be made as generic jar, with OCI vault secret name directly used in application.yaml
Simpler, yet configurable: Able to define mapping of property and secret-name via configuration, instead in source code
Now iterate over this map and populate the |
We will evaluate with OCI Vault as a Config source in #4238. |
Environment Details
Problem Description
javax:
sql:
DataSource:
slDataSource:
dataSourceClassName: org.h2.jdbcx.JdbcDataSource
dataSource:
url: jdbc:h2:mem:slPU
user: sa
password: "XXX"
The text was updated successfully, but these errors were encountered: