Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add helidon-config-yaml-mp to helidon-microprofile-config #4375

Closed
klustria opened this issue Jun 9, 2022 · 3 comments
Closed

Add helidon-config-yaml-mp to helidon-microprofile-config #4375

klustria opened this issue Jun 9, 2022 · 3 comments
Assignees
Milestone

Comments

@klustria
Copy link
Member

klustria commented Jun 9, 2022

Environment Details

  • Helidon Version: 2.5.1 and 3
  • Helidon MP

Problem Description

After adding #4218 and #4254 into 2.x and 3.x respectively, to add Hocon/Json MP support and make Meta-Config extensible, helidon-config-yaml-mp is not part of helidon-microprofile-configbecause it was decoupled from helidon-config-mp which is a part of that config bundle. The tests did not catch this because mostly, we mostly include helidon-microprofile-server which loads it indirectly via helidon-microprofile-cdi. Using bundles like helidon-microprofile or helidon-microprofile-core won't have this issue because helidon-config-yaml-mp will be indirectly included via helidon-microprofile-server. However if helidon-microprofile-config is only used without helidon-microprofile-server then there may be a backward incompatibility, but I'm not even sure if such a scenario exist.

@klustria klustria self-assigned this Jun 9, 2022
@m0mus m0mus added this to the 3.0.0 milestone Jun 9, 2022
@klustria
Copy link
Member Author

klustria commented Jun 14, 2022

Workaround (for now, add this as a dependency):

        <dependency>
             <groupId>io.helidon.config</groupId>
             <artifactId>helidon-config-yaml-mp</artifactId>
         </dependency>

In the future (2.5.2 onwards), use:

        <dependency>
            <groupId>io.helidon.microprofile.config</groupId>
            <artifactId>helidon-microprofile-config</artifactId>
        </dependency>

as mentioned in the MP config doc: https://helidon.io/docs/v2/#/mp/config/01_introduction

Furthermore, this should not be a problem if any of the following dependencies is used: helidon-microprofile-server or helidon-microprofile-cdi or any of the helidon bundles: (helidon-microprofile or helidon-microprofile-core).

@klustria
Copy link
Member Author

klustria commented Jun 16, 2022

@klustria
Copy link
Member Author

Going forward, in 2.5.2 and in 3, use below dependency to include all default MicroProfile Config including helidon-config-yaml-mp:

        <dependency>
            <groupId>io.helidon.microprofile.config</groupId>
            <artifactId>helidon-microprofile-config</artifactId>
        </dependency>

@m0mus m0mus added this to Backlog Aug 12, 2024
@m0mus m0mus moved this to Closed in Backlog Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

No branches or pull requests

2 participants