From c39b6d8ee51ff7b138f73f211c6bc962e4c6600b Mon Sep 17 00:00:00 2001 From: Maxim Nesen Date: Wed, 25 Oct 2023 14:30:00 +0200 Subject: [PATCH 1/2] Examples validation flow for external examples repo Signed-off-by: Maxim Nesen --- .github/workflows/validate.yaml | 18 +++++++++++++++--- 1 file changed, 15 insertions(+), 3 deletions(-) diff --git a/.github/workflows/validate.yaml b/.github/workflows/validate.yaml index 25a93894ca0..dd9121fa214 100644 --- a/.github/workflows/validate.yaml +++ b/.github/workflows/validate.yaml @@ -19,6 +19,9 @@ env: JAVA_VERSION: '17' JAVA_DISTRO: 'oracle' MAVEN_HTTP_ARGS: '-Dmaven.wagon.httpconnectionManager.ttlSeconds=60 -Dmaven.wagon.http.retryHandler.count=3' + HELIDON_EXAMPLES_REPOSITORY: 'helidon-io/helidon-examples.git' # external examples repository + HELIDON_EXAMPLES_BUILD_BRANCH: 'dev-3.x' # validation branch for examples + HELIDON_EXAMPLES_CHECKOUT_FOLDER: 'helidon-examples' # local checkout folder for validation branch concurrency: group: ${{ github.workflow }}-${{ github.ref }} @@ -121,12 +124,13 @@ jobs: run: etc/scripts/github-tck.sh examples: timeout-minutes: 30 + continue-on-error: true strategy: matrix: os: [ ubuntu-20.04, macos-latest ] runs-on: ${{ matrix.os }} steps: - - uses: actions/checkout@v3 + - uses: actions/checkout@v4 - name: Set up JDK ${{ env.JAVA_VERSION }} uses: actions/setup-java@v3.11.0 with: @@ -135,8 +139,16 @@ jobs: cache: maven - name: Maven build run: | - mvn -B -e "-Dmaven.test.skip=true" $MAVEN_HTTP_ARGS -DskipTests -Ppipeline install - echo "TBD: validate examples from external repository" + mvn -B -e "-Dmaven.test.skip=true" $MAVEN_HTTP_ARGS -DskipTests -Ppipeline install + - name: Examples checkout + uses: actions/checkout@v4 + with: + fetch-depth: '0' + repository: ${{ env.HELIDON_EXAMPLES_REPOSITORY }} + ref: ${{ env.HELIDON_EXAMPLES_BUILD_BRANCH }} + path: ${{ env.HELIDON_EXAMPLES_CHECKOUT_FOLDER }} + - name: Examples build + run: etc/scripts/build-examples.sh archetypes: timeout-minutes: 30 strategy: From 8628524e10e62a2d8027cc939522b74796c0d12a Mon Sep 17 00:00:00 2001 From: Romain Grecourt Date: Fri, 1 Mar 2024 13:24:20 -0800 Subject: [PATCH 2/2] inline values instead of using variables --- .github/workflows/validate.yaml | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/.github/workflows/validate.yaml b/.github/workflows/validate.yaml index dd9121fa214..029036c5b9c 100644 --- a/.github/workflows/validate.yaml +++ b/.github/workflows/validate.yaml @@ -19,9 +19,6 @@ env: JAVA_VERSION: '17' JAVA_DISTRO: 'oracle' MAVEN_HTTP_ARGS: '-Dmaven.wagon.httpconnectionManager.ttlSeconds=60 -Dmaven.wagon.http.retryHandler.count=3' - HELIDON_EXAMPLES_REPOSITORY: 'helidon-io/helidon-examples.git' # external examples repository - HELIDON_EXAMPLES_BUILD_BRANCH: 'dev-3.x' # validation branch for examples - HELIDON_EXAMPLES_CHECKOUT_FOLDER: 'helidon-examples' # local checkout folder for validation branch concurrency: group: ${{ github.workflow }}-${{ github.ref }} @@ -144,9 +141,9 @@ jobs: uses: actions/checkout@v4 with: fetch-depth: '0' - repository: ${{ env.HELIDON_EXAMPLES_REPOSITORY }} - ref: ${{ env.HELIDON_EXAMPLES_BUILD_BRANCH }} - path: ${{ env.HELIDON_EXAMPLES_CHECKOUT_FOLDER }} + repository: helidon-io/helidon-examples.git + ref: dev-3.x + path: helidon-examples - name: Examples build run: etc/scripts/build-examples.sh archetypes: