Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add send with squads to utils #569

Closed
wants to merge 2 commits into from
Closed

Conversation

Perronef5
Copy link
Contributor

No description provided.

Copy link
Collaborator

@ChewingGlass ChewingGlass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't you need to also remove it from helium-admin-cli?

@Perronef5
Copy link
Contributor Author

Don't you need to also remove it from helium-admin-cli?

Sigh

@Perronef5 Perronef5 force-pushed the add-send-with-squads-to-utils branch from 1fd7b36 to e11633e Compare February 9, 2024 03:21
@ChewingGlass
Copy link
Collaborator

@Perronef5 builds still failing.

Also thinking we may want to make this its own package. Or at least put it in its own file and export explicitly by name from index.ts so it can be tree shaken. Basically every package we have imports spl-utils, so they'll all get a needless squads sdk in their bundle

@Perronef5 Perronef5 closed this Feb 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants