Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace unicode-general-category with icu-properties #10989

Merged
merged 1 commit into from
Jun 18, 2024
Merged

Replace unicode-general-category with icu-properties #10989

merged 1 commit into from
Jun 18, 2024

Conversation

kirawi
Copy link
Member

@kirawi kirawi commented Jun 18, 2024

Resolves #10981

@the-mikedavis the-mikedavis added the A-dependencies Area: Dependency label Jun 18, 2024
@pascalkuthe pascalkuthe merged commit 9b7dffb into helix-editor:master Jun 18, 2024
6 checks passed
@kirawi kirawi deleted the category branch June 18, 2024 16:38
@kirawi
Copy link
Member Author

kirawi commented Jun 20, 2024 •
edited
Loading

Unfortunately url reverted that change for the time being servo/rust-url@54346fa. See servo/rust-url#937 for the rationale. Should we revert this commit?

kirawi added a commit to kirawi/helix that referenced this pull request Jun 21, 2024
@kirawi
Revert "Replace unicode-general-category with icu-properties (helix-e…
5ef5460 
…ditor#10989)"

This reverts commit 9b7dffb.
@kirawi kirawi mentioned this pull request Jun 21, 2024
Merged
archseer pushed a commit that referenced this pull request Jun 23, 2024
@kirawi
Revert "Replace unicode-general-category with icu-properties (#10989)" (
b55cb3a 
#11006)

This reverts commit 9b7dffb.
Grulfen pushed a commit to Grulfen/helix that referenced this pull request Jul 4, 2024
@kirawi @Grulfen
Replace unicode-general-category with icu-properties (helix-editor#10989
af6115a 
)
smortime pushed a commit to smortime/helix that referenced this pull request Jul 10, 2024
@kirawi
Replace unicode-general-category with icu-properties (helix-editor#10989
b2f7267 
)
smortime pushed a commit to smortime/helix that referenced this pull request Jul 10, 2024
@kirawi
Revert "Replace unicode-general-category with icu-properties (helix-e…
0564285 
…ditor#10989)" (helix-editor#11006)

This reverts commit 9b7dffb.
mxxntype pushed a commit to mxxntype/helix that referenced this pull request Aug 14, 2024
@kirawi @mxxntype
Replace unicode-general-category with icu-properties (helix-editor#10989
57d2380 
)
mxxntype pushed a commit to mxxntype/helix that referenced this pull request Aug 14, 2024
@kirawi @mxxntype
Revert "Replace unicode-general-category with icu-properties (helix-e…
7eb0488 
…ditor#10989)" (helix-editor#11006)

This reverts commit 9b7dffb.
kyruzic pushed a commit to kyruzic/helix that referenced this pull request Sep 27, 2024
@kirawi @kyruzic
Revert "Replace unicode-general-category with icu-properties (helix-e…
7dce476 
…ditor#10989)" (helix-editor#11006)

This reverts commit 9b7dffb.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pascalkuthe pascalkuthe pascalkuthe approved these changes

@the-mikedavis the-mikedavis the-mikedavis approved these changes

Assignees
No one assigned
Labels
A-dependencies Area: Dependency
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Replace unicode-general-category with icu-properties
3 participants
@kirawi @the-mikedavis @pascalkuthe