Fix data shape for MaxHeightImage construction #56
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm seeing crashes when doing anything with funmap in simulation:
ros_numpy will set the shape of the points buffer from a PCL message to the image dimensions (W,H), but this causes the underlying numba implementation to blow up when it tries to iterate over the points as though they were in a flat array:
stretch_ros/stretch_funmap/src/stretch_funmap/numba_height_image.py
Line 443 in b414df3
This patch ensures that a flat view of the data is passed through.
I'm not sure what would let others avoid this issue in the past. Maybe the real camera doesn't set the size fields on the message? It does not appear that this extra shape information is used by the rest of the code so the iteration would be the only place where differences would become apparent.