Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add screenshot functionality to Screencast and choose storage location #206

Open
louies0623 opened this issue Sep 12, 2023 · 11 comments
Open

Comments

@louies0623
Copy link
Contributor

louies0623 commented Sep 12, 2023

Add a screenshot function to Screencast and select the storage location, which is more convenient when needed.

@louies0623 louies0623 changed the title Screencast - Adds screenshot functionality Add screenshot functionality to Screencast and choose storage location Sep 12, 2023
@Hierosme
Copy link

Look not really hard to do.

Here an exemple:
https://github.com/Python-Devs-Brasil/PyQt5-Tutorials/blob/master/Post-2(QtCore)/screenshot.py

Informations:
https://flylib.com/books/en/2.585.1.260/1/

Technical details:
https://stackoverflow.com/questions/25056754/how-to-grab-a-desktop-screenshot-with-pyqt

@probonopd
Copy link
Member

probonopd commented Sep 27, 2023

screenshot.py works.

Now, how do we get this on Command-Shift-3? Possibly it would be best to integrate this functionality into Menu which is running all the time and hence can catch the Command-Shift-3 shortcut at all times.

Storage location should be the Desktop.

@Hierosme
Copy link

May i add Grab.app inside Utilities then use screenshot.py as base.

If look the original Grab.app it havent a lot to do. 3 dialogs + Menu (For shortcut)

@Hierosme
Copy link

For Select Area or Window screenshot it is require to use low level lib like XLib.

it have a exemple here:
https://www.initbrain.fr/code/2015/screenshot-tool/

Unfortunally thta is the only way ...

the code work under helloSystem if install pyton lib via pip install xlib

we can do the bad boys and include the python xlib inside the grab.app...
what about add python xlib inside helloSytem ?

@Hierosme
Copy link

Hierosme commented Sep 28, 2023

I havent resist to make a try #217 about ScreenShoter.
I have use as base the screenshot.py and create a UI via QDesigner.

All ready implemented

  • Save
  • Save as
  • Print (Then print to PDF)
  • Print Setup
  • Copy in clipbloard
  • Take entire screenshot
  • Custum class for Image Preview it permit elastic resize
  • About dialog

I hope you'll enjoy it.

@probonopd
Copy link
Member

The most important feature (for me) would be Command-Shift-3, then taking and directly saving the screenshot on the desktop while playing the camera sound, without asking further questions. I will likely implement this in Menu.app, since it is always running.

@Hierosme
Copy link

Command-Shift-3 is a global shortcut, but it is a service provide by a utility like Grab.app.

That is possible to call a dedicated entry point.

Normaly under OsX the Menu.app recive services from Application then the Menu is the entry point for the user.

The Documentation say:
You can create screen shots without Grab.app. Press Command-Shift-3 to capture the entire screen or Command-Shift-4 to capture a portion of the screen. The screen shot is automatically saved on the desktop as a PDF file.

Grab.app is the good App suppose to provide a ScreenShoot for a window with multy screen , a timer , etc ... (That require to speack with pyXLib)

@Hierosme
Copy link

After think a moment here (for me) the best require feature.

I got 2 usages

  • One for documentation write where i take screenshot, grop a area and save file under a special name.
  • On other for hight speed screenshoot during a meeting

For hight speed meeting screenshot i need (Require helloSystem Menu.app global shortcut)

  • Hight speed global shortcut
  • Save a serie of pictures without name file confict
  • Be sure everything is captured WITHOUT any intervention (Ultra critical)

For documentation i need (Require pyXLib module installation)

  • Take a picture of a window
  • Take a picture of a specifed window with a timer
  • Take a picture of entire screen
  • Take a picture of entire screen with a timer
  • Save a serie of pictures without name file confict
  • Post procession (Zoom, Grop area)
  • Copy to my clipboard for share screenshoot of my work

@Hierosme
Copy link

I propose to make the ScreenShot effort for helloSystem users.
By have simple and powerfull ScreenShot tools , users we report easilly trouble, and in general got more helloSystem screenshoot under internet.

@Hierosme
Copy link

A issue have been create to deal with the case of hight speed meeting screenshot:
helloSystem/Menu#169

@Hierosme
Copy link

I think we should open a new issue to address the Screenshot for documentation and bug report cases.
The global shortcurt hightspeed shortcut have been address by a issue in Menu.app

then we should consider ScreenCast should not have it responssability

from my point i have take a look on ScreenCast.app code , the code is not really ready to deal with Screenshot, because the entire job is send to ffmpeg.

Grab.app is a good candidate but require work with pyXlib

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants