Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EcdsaSecp256k1Signature2019 matchProof should support relative paths id of verificationMethod #50

Open
lemoustachiste opened this issue Sep 15, 2022 · 1 comment

Comments

@lemoustachiste
Copy link
Contributor

This block https://github.com/hellobloom/ssi-sdk/blob/main/packages/ecdsa-secp256k1-signature-2019/src/index.ts#L194-L197 expects to match the key id and the verificationMethod id.

However, as per this discussion: decentralized-identity/ion#285, relative paths in verificationMethod of a DID document are a valid format to reference a key id.

When running verification with EcdsaSecp256k1Signature2019 in the case of a relative path definition in the DID document, the validation fails with:

Did not verify any proofs; insufficient proofs matched the acceptable suite(s) and required purpose(s).

Because the above check does not match the relative path.

I don't mind opening a PR if that's easier on you, but there needs to be a way to also check that the controller is valid, and I'm not sure if we've got access to that.

@djvs
Copy link
Contributor

djvs commented Oct 14, 2022

Sorry for delay. Please do PR and I can review.

djvs pushed a commit that referenced this issue Nov 19, 2022
* fix(matchProof): allow checking against relative path key id in did document

* chore(Deps): list did-common-typescript in package-lock

* chore(Deps): fix lerna complaining about missing deps

* style(Lint): lint
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants