Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Yosep Novento Nugroho #6

Open
ventodeco opened this issue Oct 30, 2019 · 25 comments
Open

Yosep Novento Nugroho #6

ventodeco opened this issue Oct 30, 2019 · 25 comments
Assignees
Labels
ACCEPTED proposal is ready to execute

Comments

@ventodeco
Copy link

ventodeco commented Oct 30, 2019

Name: Yosep Novento Nugroho
Nim: 1303180081
Major: S1 Teknologi Informasi
Github Account: https://github.com/ventodeco
Proposal Link: https://docs.google.com/document/d/1MU2uM3i8Jk2cv-Ap_aq-hb-MWc0GptN4M9geUISzzRk/edit?usp=sharing
Project Link: https://github.com/ventodeco/notonlycodedistro.git

@BlinfoldKing
Copy link
Member

@ventodeco jelasin kenapa pake php, trus itu kan ecommerce cara kamu implement payment gateway nya mau gimana?

@BlinfoldKing
Copy link
Member

di bagian cara kerjanya tambahin cara kerja sistemnya juga mau pake pattern apa, terhubung kemana aja, butuh apa aja, alur datanya bagaimana

@BlinfoldKing
Copy link
Member

itu bukan design pattern baca2 ini dulu ya @ventodeco
https://sourcemaking.com/design_patterns

@BlinfoldKing
Copy link
Member

sama php ini pake framework atau native

@vayupranaditya @wisn

@ventodeco
Copy link
Author

Kalau misal anti pattern bagaimana kak?

@BlinfoldKing
Copy link
Member

lah jangan, soalnya itu justru yang ngebedain engineer sama developer

@ventodeco
Copy link
Author

udah di update kak, apa design pattern seperti itu?

@BlinfoldKing
Copy link
Member

BlinfoldKing commented Oct 31, 2019

@vayupranaditya
@jeremylombogia

@BlinfoldKing
Copy link
Member

BlinfoldKing commented Oct 31, 2019

yakin gitu aja cukup ga untuk project segede gini? trus itu maksudnya builder bakal dipake register user baru gimana caranya?

trus transaksinya mau dihandle gimana?

@BlinfoldKing BlinfoldKing added the MAJOR REVISION your proposal need more information label Oct 31, 2019
@wisn
Copy link
Member

wisn commented Oct 31, 2019

Concern utamaku dari proyek ini tuh cukup atau ngga waktunya buat develop e-commerce. Kalau bener-bener from scratch menurutku gamungkin bisa kelar semua fitur yang dibutuhkannya. Dari yang aku liat, ini bakal ada multi-level user. Setidaknya, bakal ada level user sebagai penjual dan level user sebagai pembeli. Saranku agar mempermudah kamu dalam masuk Proclub, kerjakan proyek yang tidak terlalu besar aja.

Daripada ngerjain e-commerce, mending bikin website online shop untuk produkmu sendiri. Jadi kamu cuma perlu develop satu level user aja yaitu pembeli. Login-nya bisa pake API Google gitu biar gausah implement dari awal banget. Untuk payment pake Stripe aja biar tinggal consume API. Intinya manfaatkan sebaik mungkin service-service yang bisa dipakai.

Proyek Proclub itu cuma buat approve kamu bisa ngoding atau ngga. Ngga perlu literally from scratch. Ambil jalan termudah aja tapi hasilnya cukup bagus.

@ventodeco Gimana?

@ventodeco
Copy link
Author

Oke siap makasih bang wisnu pencerahannya @wisn

@ventodeco
Copy link
Author

@BlinfoldKing tolong cek lagi kak

@wisn
Copy link
Member

wisn commented Nov 1, 2019

Okay. ACC from me. Sung ngoding

Cc @BlinfoldKing

@BlinfoldKing
Copy link
Member

mata pancing

@BlinfoldKing BlinfoldKing added ACCEPTED proposal is ready to execute and removed MAJOR REVISION your proposal need more information labels Nov 1, 2019
@wisn
Copy link
Member

wisn commented Nov 2, 2019

@ventodeco Project link-nya mana?

@ventodeco
Copy link
Author

@wisn masih proses bang, belum di push

@wisn
Copy link
Member

wisn commented Nov 11, 2019

@ventodeco Any update? Kalo ada problem tolong langsung ngomong aja nanti kami coba bantu

@ventodeco
Copy link
Author

@wisn update baru register page, tolong di review bang

@jeremyfl
Copy link
Member

@ventodeco aku ada request edit access untuk keperluan review proposal nya, ada yang harus diebenerin dari proposalnya.

Setelah lihat code nya mungkin yang perlu di improve itu indenting / kerapihan code nya nya, coba kamu install plugin either Prettier, Beautify di Text Editor kamu, itu rata rata ada.

@ventodeco
Copy link
Author

@jeremylombogia udah aku bagi aksesnya bang

Oke nanti saya install pluginnya + ngrapiin kodenya bang

@wisn
Copy link
Member

wisn commented Nov 15, 2019

@ventodeco Gapengen pake framework?

@ventodeco
Copy link
Author

@wisn mungkin dimatengin pake native dulu bang

@ventodeco
Copy link
Author

@wisn @jeremylombogia udah di update kak

@ventodeco
Copy link
Author

@wisn @jeremylombogia bang, kok itu subtotal ga keubah ya waktu input di keranjang diubah, tolongdireview di keranjang.php

@BlinfoldKing
Copy link
Member

mantul

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ACCEPTED proposal is ready to execute
Projects
None yet
Development

No branches or pull requests

5 participants