Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

[incubator/taiga] Release 0.2.0 (initial release) #7272

Closed
wants to merge 2 commits into from

Conversation

mvitale1989
Copy link

What this PR does / why we need it:
This PR adds the taiga project management application chart into the incubator directory.

Special notes for your reviewer:
When provisioning PostgreSQL (persistence.deployPostgres: true, which is the default), If using a release name other than taiga, the parameter taiga.dbHost must be tuned accordingly, as documented in the readme.

Remarks:

  • This chart is based on mvitale1989/docker-taiga, a fork of the benhutchins/docker-taiga community-mantained image, on which some tunings have been done to adapt it to work well under Kubernetes. There is a currently open PR for merging these change back into it, and then switch to using the upstream image.
  • The taiga code itself is released under the AGPL-3.0 license, which grants permission to distribute the software.
  • The taiga-events ancillary feature is currently not implemented, but there's no downside to it other than not having live updates in the web interface

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mvitale1989
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: mgoodness

If they are not already assigned, you can assign the PR to them by writing /assign @mgoodness in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 21, 2018
@k8s-ci-robot
Copy link
Contributor

Hi @mvitale1989. Thanks for your PR.

I'm waiting for a helm member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Aug 21, 2018
@mvitale1989 mvitale1989 changed the title Add Taiga to the incubator directory [incubator/taiga] Release 0.2.0 (initial release) Aug 21, 2018
@mvitale1989
Copy link
Author

/assign @mgoodness

incubator/taiga/LICENSE Outdated Show resolved Hide resolved
incubator/taiga/requirements.yaml Outdated Show resolved Hide resolved
### Default values for taiga.

image:
repository: mvitale1989/docker-taiga
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This image appears to be a new on (for this?) that's manually created. What's the plan for updates and maintenance?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a fork of benhutchins/docker-taiga, which i slightly adapted for clean usage in Kubernetes (added option of using as an init container, and implemented proper termination signal handling). My goal is merging the changes back in the original repository, for which i already have a PR open, and switch back to that image after the merge; but depending on how this process goes i might maintain the fork with these adaptations, and merge upstream changes back into it.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It appears https://github.com/benhutchins/docker-taiga doesn't have an up to date public image on docker hub. Once your changes land where will they be shared with others? How will things be kept up to date?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The author has set an automated build job for the repo on docker hub. The builds failed for a while due to an error that my PR resolves, as you can see in my automated builds, so once the changes are merged upstream, the latest image will be publicly available.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The author of the original image has been unresponsive so far. Given my repo also diverged substantially in the provisioning approach, i will keep using and maintaining my own image.

@mattfarina mattfarina added the Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). label Aug 27, 2018
@quater
Copy link
Contributor

quater commented Aug 28, 2018

I have tried this Taiga chart and found it working!

@stale
Copy link

stale bot commented Oct 24, 2018

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Any further update will cause the issue/pull request to no longer be considered stale. Thank you for your contributions.

@stale stale bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 24, 2018
@mvitale1989
Copy link
Author

Any news on the review? If not, i'd have some small improvements i'd like to integrate before the that. I'll push them over the weekend.

@stale stale bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 25, 2018
@helm-bot helm-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). labels Oct 28, 2018
@helm-bot helm-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Oct 28, 2018
Signed-off-by: Mario Vitale <[email protected]>
@helm-bot helm-bot added Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Oct 28, 2018
@stale
Copy link

stale bot commented Nov 27, 2018

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Any further update will cause the issue/pull request to no longer be considered stale. Thank you for your contributions.

@stale stale bot added lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Nov 27, 2018
Signed-off-by: Mario Vitale <[email protected]>
@helm-bot helm-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Dec 18, 2018
@stale
Copy link

stale bot commented Jan 17, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Any further update will cause the issue/pull request to no longer be considered stale. Thank you for your contributions.

@stale stale bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 17, 2019
@stale
Copy link

stale bot commented Jan 31, 2019

This issue is being automatically closed due to inactivity.

@stale stale bot closed this Jan 31, 2019
@themightychris
Copy link

@mvitale1989 did you give up on benhutchins/docker-taiga#64 or did the needed improvement end up getting merged in another way? Was that the upstream merge this PR got stuck on?

Looking to deploy from this myself soon

@mvitale1989
Copy link
Author

@themightychris there simply didn't seem to be much interest from neither the upstream image maintainer, nor the helm community for this PR. At least that's my perception, as even after the requested changes there was no feedback from the reviewers.

I am now maintaining my own fork of the image with all the required fixes and more (readme would need a rewrite though), but i don't think it'd be merged anymore as it has diverged quite a lot.
You can now find the chart in mvitale1989/helm-taiga, which i'm using to deploy my own taiga instances

@themightychris
Copy link

thanks for keeping your work shared @mvitale1989 ! I've got it bookmarked for my upcoming migration of my Taiga instance to k8s. I'll help you maintain these

@mvitale1989
Copy link
Author

@themightychris thanks, much appreciated!

@Zageron
Copy link

Zageron commented Aug 28, 2019

What ever happened to this chart? I'd love to see it become officially maintained.

@zakkg3
Copy link
Collaborator

zakkg3 commented Feb 21, 2020

Plus 1

@vkmc
Copy link

vkmc commented Aug 12, 2020

+1

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants