-
Notifications
You must be signed in to change notification settings - Fork 16.8k
[incubator/taiga] Release 0.2.0 (initial release) #7272
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: mvitale1989 If they are not already assigned, you can assign the PR to them by writing The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @mvitale1989. Thanks for your PR. I'm waiting for a helm member to verify that this patch is reasonable to test. If it is, they should reply with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/assign @mgoodness |
### Default values for taiga. | ||
|
||
image: | ||
repository: mvitale1989/docker-taiga |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This image appears to be a new on (for this?) that's manually created. What's the plan for updates and maintenance?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's a fork of benhutchins/docker-taiga, which i slightly adapted for clean usage in Kubernetes (added option of using as an init container, and implemented proper termination signal handling). My goal is merging the changes back in the original repository, for which i already have a PR open, and switch back to that image after the merge; but depending on how this process goes i might maintain the fork with these adaptations, and merge upstream changes back into it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It appears https://github.com/benhutchins/docker-taiga doesn't have an up to date public image on docker hub. Once your changes land where will they be shared with others? How will things be kept up to date?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The author has set an automated build job for the repo on docker hub. The builds failed for a while due to an error that my PR resolves, as you can see in my automated builds, so once the changes are merged upstream, the latest image will be publicly available.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The author of the original image has been unresponsive so far. Given my repo also diverged substantially in the provisioning approach, i will keep using and maintaining my own image.
I have tried this Taiga chart and found it working! |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Any further update will cause the issue/pull request to no longer be considered stale. Thank you for your contributions. |
Any news on the review? If not, i'd have some small improvements i'd like to integrate before the that. I'll push them over the weekend. |
Signed-off-by: Mario Vitale <[email protected]>
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Any further update will cause the issue/pull request to no longer be considered stale. Thank you for your contributions. |
Signed-off-by: Mario Vitale <[email protected]>
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Any further update will cause the issue/pull request to no longer be considered stale. Thank you for your contributions. |
This issue is being automatically closed due to inactivity. |
@mvitale1989 did you give up on benhutchins/docker-taiga#64 or did the needed improvement end up getting merged in another way? Was that the upstream merge this PR got stuck on? Looking to deploy from this myself soon |
@themightychris there simply didn't seem to be much interest from neither the upstream image maintainer, nor the helm community for this PR. At least that's my perception, as even after the requested changes there was no feedback from the reviewers. I am now maintaining my own fork of the image with all the required fixes and more (readme would need a rewrite though), but i don't think it'd be merged anymore as it has diverged quite a lot. |
thanks for keeping your work shared @mvitale1989 ! I've got it bookmarked for my upcoming migration of my Taiga instance to k8s. I'll help you maintain these |
@themightychris thanks, much appreciated! |
What ever happened to this chart? I'd love to see it become officially maintained. |
Plus 1 |
+1 |
What this PR does / why we need it:
This PR adds the taiga project management application chart into the incubator directory.
Special notes for your reviewer:
When provisioning PostgreSQL (
persistence.deployPostgres: true
, which is the default), If using a release name other thantaiga
, the parametertaiga.dbHost
must be tuned accordingly, as documented in the readme.Remarks: