Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"+1 month" considered harmful #13

Open
kenwest opened this issue Nov 29, 2013 · 0 comments
Open

"+1 month" considered harmful #13

kenwest opened this issue Nov 29, 2013 · 0 comments

Comments

@kenwest
Copy link
Contributor

kenwest commented Nov 29, 2013

If an instalment is paid on Oct 31, then "+1 month" will schedule the next payment on Dec 1, as there is no Nov 31.

I suggest we use the cycle_day column in the Recurring Contribution table to avoid this.

  • Pay the first instalment on the day it's scheduled (when the original Contribution is Pending)
  • Pay subsequent instalments on the 'cycle_day' of the month
  • cycle_day has a value from 1 to 28. If is set to the day-of-the-month for the first instalment, but '29', '30', and '31' round down to '28'
  • Thus subsequent payments are a month apart and no months are skipped

Should I go ahead and code this?

kenwest pushed a commit to kenwest/CiviCRM-eWay-recurring-payment-processor that referenced this issue Mar 8, 2015
Don't need to set UserId to zero in CiviCRM 4.5 or above
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant