Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: support download zls #53

Open
jinzhongjia opened this issue Jul 27, 2024 · 11 comments
Open

Feature Request: support download zls #53

jinzhongjia opened this issue Jul 27, 2024 · 11 comments
Labels
enhancement New feature or request

Comments

@jinzhongjia
Copy link
Contributor

Maybe we can add feat to download zls, and just like using exec with zig, it also can use on zls!

@hendriknielaender
Copy link
Owner

Yeah that's a cool idea.

@hendriknielaender hendriknielaender added the enhancement New feature or request label Jul 27, 2024
@jinzhongjia
Copy link
Contributor Author

I'm trying to add zls support
But maybe we need to modify the command line, such as zmv zls i 0.13.0 or zvm i 0.13.0 --zls

@jinzhongjia
Copy link
Contributor Author

I have a little question, why did you add a lot of assert in the source code?

I find that many assert are unnecessary

@hendriknielaender
Copy link
Owner

hendriknielaender commented Jul 30, 2024

I have a little question, why did you add a lot of assert in the source code?

I find that many assert are unnecessary

I added it only to three functions. One in update_current to check that the zig_path and symlink_path variables are not empty before attempting to update the current symbolic link or directory.

And the others are copy_dir and content. IMHO that's not a lot. In these cases, the assertions act as security checks.

@jinzhongjia
Copy link
Contributor Author

I suggest introducing a command line parsing package. The current command function is no longer sufficient.

For example, the clap package is of very high quality.

@hendriknielaender
Copy link
Owner

I suggest introducing a command line parsing package. The current command function is no longer sufficient.

For example, the clap package is of very high quality.

What's the current limitation that we are facing? If there are no major obstacles, I want to avoid adding dependencies.

@jinzhongjia
Copy link
Contributor Author

For example, 'install 0.13.0' is designed to take only one argument, but I think 'install zig 0.13.0' is more intuitive and can be distinguished from 'install zls 0.13.0'. It can be installing zig for default 'install 0.13.0'.

@hendriknielaender
Copy link
Owner

#57

Currently we only need that for zls as additional argument, so something like in my draft should work.

@hendriknielaender
Copy link
Owner

@jinzhongjia how do we proceed with the zls feature? IIRC there is still something missing.

@jinzhongjia
Copy link
Contributor Author

Missing support for master branch compilation

@jinzhongjia
Copy link
Contributor Author

jinzhongjia commented Oct 15, 2024

But I don't have extra effort to deal with this issue now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants