Save view preferences in browser - Duration - Average/Max - localstorage

[AndreiTelteu]

I find it useful to remember my choice of "Max 1 min" or duration 1 hour. I am interested in making a pull request for this feature if people think it's useful.
But my question is: should this view filters be remembered at a node level ? or global ?
If I selected "Max 1 min" on server1, when I click server2 should it have the same setting ?
And should this setting be saved permanently using localStorage ? Or only this session using sessionStorage ?

[henrygd]

Good idea. Not sure what others would prefer but I'm fine with any of the above.

I'd probably lean towards keeping the selected setting across multiple systems, just because I can imagine it would be annoying if you prefer to see maximum values and need to change it every time.

I also wonder if it would be better to use a single selection that applies to all charts, rather than separate ones for CPU, bandwidth, and disk.

Besides localStorage / sessionStorage, another option is to add it to the settings page under "Chart Options" and save it in user settings like we're doing with the default time period.

I'd like to add keyboard shortcuts for things like this eventually.

[monstermuffin]

I would like to have an option for the default between average/max 1 min.

I think having it global is the better choice. An option per node at the top to override this if needed for all charts under that node should suffice to override if required.

The current system of doing per graph selection is very tedious.

[henrygd]

How does this sound?

• Combine avg/max selection into one store rather than using different ones for CPU / bandwidth / disk. When it's changed on one chart, it applies to all charts.
• Leave the UI as is for the time being, with the select fields on the charts. Not all charts have or need this option so the field is a useful indicator of you're looking at.
• Add an option for "Default values" to the settings page under "Chart Options." This would save to user settings like the default time period currently does. Maybe call it chartVals with possible values of avg or max, or maybe just do chartMax: true.
• When navigating to a new system, it resets to whatever the user has chosen on the settings page (same as how the default chart time works).

If the settings page stuff is tricky to figure out, don't worry about it. I'll add it in after. This is the first React app I've done in four or five years and it's not exactly a thing of beauty.

[monstermuffin]

I think this is a good way to go about it.