Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(newlib): using kernel networking, instead of lwip #1237

Merged
merged 4 commits into from
Jun 4, 2024

Conversation

CarlWachter
Copy link
Contributor

@CarlWachter CarlWachter commented May 29, 2024

Adapted cfg to now use kernel networking with newlib feature.

Closes #1165

@CarlWachter CarlWachter changed the title Removed lwip feat(newlib) using kernel networking, instead of lwip May 29, 2024
@mkroening mkroening self-assigned this May 29, 2024
Copy link
Member

@mkroening mkroening left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is some overlap with #1165. Could you integrate those changes and test? :)

@CarlWachter CarlWachter force-pushed the no_lwip branch 2 times, most recently from 8bf9278 to e21dcda Compare May 30, 2024 18:46
@CarlWachter
Copy link
Contributor Author

There is some overlap with #1165. Could you integrate those changes and test? :)

I cherry-picked the commits in question and everything still works 👍

@CarlWachter CarlWachter requested a review from mkroening May 31, 2024 06:44
Copy link
Member

@mkroening mkroening left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I cherry-picked the commits in question and everything still works 👍

Awesome, could you remove the merge commit? :)

@CarlWachter CarlWachter force-pushed the no_lwip branch 2 times, most recently from 7ccf585 to 2708358 Compare May 31, 2024 13:51
@CarlWachter
Copy link
Contributor Author

Awesome, could you remove the merge commit? :)

Done. I spent half an hour looking for it this morning, turns out i accidentally hit "Update branch" on Github and never pulled the change to my local, so i was searching for something that didn't exist :)

@CarlWachter CarlWachter force-pushed the no_lwip branch 3 times, most recently from 2708358 to 58a2e3b Compare May 31, 2024 15:09
@mkroening mkroening changed the title feat(newlib) using kernel networking, instead of lwip feat(newlib): using kernel networking, instead of lwip Jun 4, 2024
@mkroening mkroening enabled auto-merge June 4, 2024 10:30
@mkroening mkroening added this pull request to the merge queue Jun 4, 2024
Merged via the queue into hermit-os:main with commit 285f28a Jun 4, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants