uhyve: don't panic on initial unmap if page is not mapped #1508
+5
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkroening
reviewed
Dec 10, 2024
| flush.ignore(); | ||
| match page_table.unmap(page) { | ||
| Ok((_frame, flush)) => flush.ignore(), | ||
| Err(UnmapError::PageNotMapped) => {} // If it wasn't mapped, that's not an issue |
There was a problem hiding this comment.
This is similar to what we do in paging::unmap. Would it make sense to log this too?
There was a problem hiding this comment.
I don't think so unless you like ~510 lines of info log output on a normal boot.
There was a problem hiding this comment.
We would not have to use info. But if you don't think a debug or trace is useful, that's fine for me.
There was a problem hiding this comment.
Honestly, I don't think it is worth it.
There was a problem hiding this comment.
Should we add a TODO into the comment or will this be tracked in an issue?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm reworking the initial page mapping of uhyve to resolve hermit-os/uhyve#426, but the kernel currently expects the first GiB to be mapped and panics otherwise.
In a transition phase, it makes sense to at least not panic if the page is not mapped.