Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MacOS: Update vm exit handling to be on par with Linux #802

Closed
jounathaen opened this issue Nov 21, 2024 · 1 comment
Closed

MacOS: Update vm exit handling to be on par with Linux #802

jounathaen opened this issue Nov 21, 2024 · 1 comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed MacOS

Comments

@jounathaen
Copy link
Member

On Linux, all other VM threads are ended, once a single one has completed execution. This solves Uhyve hanging on failures of hermit.

uhyve/src/linux/mod.rs

Lines 134 to 141 in 06d18a1

// Wait for one vCPU to return with an exit code.
barrier.wait();
for thread in &threads {
KickSignal::pthread_kill(thread.as_pthread_t()).unwrap();
}

The macOS code should be updated to be on-par with the Linux version.
@jounathaen jounathaen added help wanted Extra attention is needed good first issue Good for newcomers MacOS labels Nov 21, 2024
@jounathaen jounathaen mentioned this issue Nov 21, 2024
Closed
jounathaen added a commit that referenced this issue Jan 21, 2025
@jounathaen
Refactoring: Made vCPUs part of the VM struct and store arcs to
fdce1c6 
peripherals in special struct.

This is a preparation for better frequency detection, as we need the
vcpus to be existing before the memory initialization to query the TSC
frequency from KVM.

Fixes #802
jounathaen added a commit that referenced this issue Jan 24, 2025
@jounathaen
Refactoring: Made vCPUs part of the VM struct and store arcs to
ed51f3f 
peripherals in special struct.

This is a preparation for better frequency detection, as we need the
vcpus to be existing before the memory initialization to query the TSC
frequency from KVM.

Fixes #802
jounathaen added a commit that referenced this issue Jan 28, 2025
@jounathaen
Refactoring: Made vCPUs part of the VM struct and store arcs to
f85042b 
peripherals in special struct.

This is a preparation for better frequency detection, as we need the
vcpus to be existing before the memory initialization to query the TSC
frequency from KVM.

Fixes #802
jounathaen added a commit that referenced this issue Jan 28, 2025
@jounathaen
Refactoring: Made vCPUs part of the VM struct and store arcs to
6ae33ef 
peripherals in special struct.

This is a preparation for better frequency detection, as we need the
vcpus to be existing before the memory initialization to query the TSC
frequency from KVM.

Fixes #802
jounathaen added a commit that referenced this issue Jan 28, 2025
@jounathaen
Refactoring: Made vCPUs part of the VM struct and store arcs to
ef96e3f 
peripherals in special struct.

This is a preparation for better frequency detection, as we need the
vcpus to be existing before the memory initialization to query the TSC
frequency from KVM.

Fixes #802
jounathaen added a commit that referenced this issue Jan 28, 2025
@jounathaen
Refactoring: Made vCPUs part of the VM struct and store arcs to
1ae18eb 
peripherals in special struct.

This is a preparation for better frequency detection, as we need the
vcpus to be existing before the memory initialization to query the TSC
frequency from KVM.

Fixes #802
jounathaen added a commit that referenced this issue Jan 28, 2025
@jounathaen
Refactoring: Made vCPUs part of the VM struct and store arcs to
4d6b2c2 
peripherals in special struct.

This is a preparation for better frequency detection, as we need the
vcpus to be existing before the memory initialization to query the TSC
frequency from KVM.

Fixes #802
jounathaen added a commit that referenced this issue Jan 28, 2025
@jounathaen
Refactoring: Made vCPUs part of the VM struct and store arcs to
3f4a83d 
peripherals in special struct.

This is a preparation for better frequency detection, as we need the
vcpus to be existing before the memory initialization to query the TSC
frequency from KVM.

Fixes #802
jounathaen added a commit that referenced this issue Jan 28, 2025
@jounathaen
Refactoring: Made vCPUs part of the VM struct and store arcs to
d1a69b3 
peripherals in special struct.

This is a preparation for better frequency detection, as we need the
vcpus to be existing before the memory initialization to query the TSC
frequency from KVM.

Fixes #802
jounathaen added a commit that referenced this issue Jan 28, 2025
@jounathaen
Refactoring: Made vCPUs part of the VM struct and store arcs to
f0fb6c9 
peripherals in special struct.

This is a preparation for better frequency detection, as we need the
vcpus to be existing before the memory initialization to query the TSC
frequency from KVM.

Fixes #802
github-merge-queue bot pushed a commit that referenced this issue Jan 28, 2025
@jounathaen
Refactoring: Made vCPUs part of the VM struct and store arcs to
16304c5 
peripherals in special struct.

This is a preparation for better frequency detection, as we need the
vcpus to be existing before the memory initialization to query the TSC
frequency from KVM.

Fixes #802
@jounathaen
Copy link
Member Author

This is probably fixed. But macos code is currently not tested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers help wanted Extra attention is needed MacOS
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jounathaen