Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Docker apps deployed with Container Registry #201

Open
eliasdorneles opened this issue May 29, 2019 · 4 comments
Open

Support for Docker apps deployed with Container Registry #201

eliasdorneles opened this issue May 29, 2019 · 4 comments
Labels
Heroku API Support Ticket/PR is blocked on the Heroku API supporting the use case

Comments

@eliasdorneles
Copy link

Hello!

Is there a plan to add support for Dockerized apps deployed with the Heroku Container Registry ?

I'm currently working on automating the creation of Heroku apps which use this deployment method (namely, with stack = container, no usage of buildpacks, there are no builds happening in Heroku side) and I'm evaluating what are the possibilities.

I'm currently considering forking this provider to adapt it to my needs and maybe contributing upstream if I arrive at something reusable.
I haven't found anything about this in older issues, so I'm opening this to start a discussion.

@mars
Copy link
Member

mars commented May 29, 2019

Currently, building from a Dockerfile is the only Docker container workflow supported by this Terraform provider. See: heroku_build resource.

Releasing an existing container image is only available in the pre-release Heroku API docker-releases variant. We will not implement this in heroku_formation resource, until it's moved into the stable, generally available Platform API. (I don't know when, if ever, that will happen.)

@mars mars added the Heroku API Support Ticket/PR is blocked on the Heroku API supporting the use case label May 29, 2019
@davidji99
Copy link
Collaborator

davidji99 commented Jan 11, 2021

For those that are interested, I've implemented docker container release support for my the herokux provider.

@Martinsos
Copy link

Too bad, this would be really helpful to have! I tried using this provider with supported approach, which is heroku.yml and then Heroku builds the image for us -> but building such image is really slow, in my case it takes 7 minutes for something that on my machine gets built in a minute! So having an option to push Docker image would be amazing. I understand that it is not yet part of stable API, maybe it could also be marked as experimental/non-stable feature here in this provider?

@davidji99
Copy link
Collaborator

davidji99 commented Feb 1, 2021

Hi @Martinsos,

This provider will not implement any resources using APIs that are not part of the Platform API. See previous comments by the maintainer(s) on this topic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Heroku API Support Ticket/PR is blocked on the Heroku API supporting the use case
Projects
None yet
Development

No branches or pull requests

4 participants