Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] - The shouldBlockScroll property of Popover does not work as expected #4605

Open
AnYiEE opened this issue Jan 20, 2025 · 2 comments
Open

Comments

@AnYiEE
Copy link
Contributor

AnYiEE commented Jan 20, 2025

This issue can be reproduced on the storybook. https://storybook.heroui.com/?path=/story/components-popover--with-should-block-scroll

Expected: Whether scrolling with the mouse wheel or swiping on a touchscreen device (including simulating a touchscreen device through the console), shouldBlockScroll can prevent the view from scrolling.

Currently: When sliding the screen, Popover will be closed, even if shouldCloseOnScroll is not set.

Env: Windows/Android Chrome

Copy link

linear bot commented Jan 20, 2025

@AnYiEE AnYiEE changed the title [BUG] - PopovershouldBlockScroll属性不能按预期工作 [BUG] - The shouldBlockScroll property of Popover does not work as expected Jan 20, 2025
@AnYiEE
Copy link
Contributor Author

AnYiEE commented Jan 20, 2025

Note 1: Even if shouldCloseOnScroll is explicitly set to false, the Popover will still close when sliding the screen. It seems that the click event has a higher priority, or it may be related to issues with the overlay. Possible related issues: #4603

Note 2: Only set shouldCloseOnScroll to false, when scrolling on the outside overlay, the Popover will be closed, but scrolling within the Popover will not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant