From b207833092d19252cd21588c23c2a11880f6ca3e Mon Sep 17 00:00:00 2001
From: Dimas Lanjaka <dimaslanjaka@gmail.com>
Date: Fri, 12 Jan 2024 23:28:16 +0700
Subject: [PATCH] fix(url_for): some improvement for `url_for` (#307)

Co-authored-by: uiolee <22849383+uiolee@users.noreply.github.com>
Co-authored-by: Sukka <isukkaw@gmail.com>
---
 lib/url_for.ts | 70 +++++++++++++++++++++++++++++++++++---------------
 1 file changed, 50 insertions(+), 20 deletions(-)

diff --git a/lib/url_for.ts b/lib/url_for.ts
index 7ab50408..35234a8a 100644
--- a/lib/url_for.ts
+++ b/lib/url_for.ts
@@ -5,14 +5,38 @@ import prettyUrls from './pretty_urls';
 import Cache from './cache';
 const cache = new Cache<string>();
 
-function urlForHelper(path = '/', options) {
+/**
+ * url_for options type
+ * @example
+ * // to call this type
+ * type urlOpt = Parameters<typeof import('hexo-util')['url_for']>[1];
+ */
+interface UrlForOptions {
+  relative?: boolean;
+}
+
+/**
+ * get url relative to base URL (config_yml.url)
+ * @param path relative path inside `source` folder (config_yml.source_dir)
+ * @param options
+ * @returns
+ * @example
+ * // global `hexo` must be exist when used this function inside plugin
+ * const Hutil = require('hexo-util')
+ * console.log(Hutil.url_for.bind(hexo)('path/to/file/inside/source.css')); // https://example.com/path/to/file/inside/source.css
+ */
+function urlForHelper(path = '/', options: UrlForOptions | null = {}) {
   if (/^(#|\/\/|http(s)?:)/.test(path)) return path;
 
   const { config } = this;
 
-  options = Object.assign({
-    relative: config.relative_link
-  }, options);
+  options = Object.assign(
+    {
+      relative: config.relative_link
+    },
+    // fallback empty object when options filled with NULL
+    options || {}
+  );
 
   // Resolve relative url
   if (options.relative) {
@@ -20,28 +44,34 @@ function urlForHelper(path = '/', options) {
   }
 
   const { root } = config;
-  const prettyUrlsOptions = Object.assign({
-    trailing_index: true,
-    trailing_html: true
-  }, config.pretty_urls);
+  const prettyUrlsOptions = Object.assign(
+    {
+      trailing_index: true,
+      trailing_html: true
+    },
+    config.pretty_urls
+  );
 
   // cacheId is designed to works across different hexo.config & options
-  return cache.apply(`${config.url}-${root}-${prettyUrlsOptions.trailing_index}-${prettyUrlsOptions.trailing_html}-${path}`, () => {
-    const sitehost = parse(config.url).hostname || config.url;
-    const data = new URL(path, `http://${sitehost}`);
+  return cache.apply(
+    `${config.url}-${root}-${prettyUrlsOptions.trailing_index}-${prettyUrlsOptions.trailing_html}-${path}`,
+    () => {
+      const sitehost = parse(config.url).hostname || config.url;
+      const data = new URL(path, `http://${sitehost}`);
 
-    // Exit if input is an external link or a data url
-    if (data.hostname !== sitehost || data.origin === 'null') {
-      return path;
-    }
+      // Exit if input is an external link or a data url
+      if (data.hostname !== sitehost || data.origin === 'null') {
+        return path;
+      }
 
-    // Prepend root path
-    path = encodeURL((root + path).replace(/\/{2,}/g, '/'));
+      // Prepend root path
+      path = encodeURL((root + path).replace(/\/{2,}/g, '/'));
 
-    path = prettyUrls(path, prettyUrlsOptions);
+      path = prettyUrls(path, prettyUrlsOptions);
 
-    return path;
-  });
+      return path;
+    }
+  );
 }
 
 export = urlForHelper;