We want to make contributing to this project as easy and transparent as possible.
The source of truth for this library is an internal repository; we continuously sync changes out to GitHub using FBShipIt, and test/apply pull requests against the repository after review.
If a pull request passes the public tests but has internal issues, we will not be able to merge the pull request until the internal issues are fixed; depending on the scale of the problem, this can take a few weeks.
We actively welcome your pull requests.
- Fork the repo and create your branch from
master. - If you've added code that should be tested, add tests.
- If you've changed APIs, update the documentation.
- Ensure the test suite passes.
- Make sure your code lints.
- If you haven't already, complete the Contributor License Agreement ("CLA").
In order to accept your pull request, we need you to submit a CLA. You only need to do this once to work on any of Facebook's open source projects.
Complete your CLA here: https://code.facebook.com/cla
We use GitHub issues to track public bugs. Please ensure your description is clear and has sufficient instructions to be able to reproduce the issue.
Facebook has a bounty program for the safe disclosure of security bugs. In those cases, please go through the process outlined on that page and do not file a public issue.
- 2 spaces for indentation rather than tabs
- 80 character line length
- Be consistent with existing code
- Be consistent with hackfmt
We do not follow the PSR guidelines.
By contributing to the Hack Standard Library, you agree that your contributions will be licensed under the LICENSE file in the root directory of this source tree.